Refresh OpenRouter models after setting API key - #58551
Merged
yara-blue merged 2 commits intoJun 4, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
ChihweiLHBird
force-pushed
the
openrouter-format-model-refresh
branch
from
June 4, 2026 15:22
89b4f7f to
c2b6843
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates OpenRouter provider state handling around API key changes and model fetching, ensuring the model list is kept in sync with authentication state.
Changes:
- Restart model-fetching when the API key is updated.
- Clear
available_modelsand notify the UI when the API key is missing. - Simplify error mapping when listing models.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yara-blue
approved these changes
Jun 4, 2026
yara-blue
enabled auto-merge
June 4, 2026 15:55
Contributor
|
Thanks! |
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable ## Summary Adding an OpenRouter API key did not populate the model list until the app was restarted. `set_api_key` stored the credential but never triggered a model fetch, so until re-authentication happened (on restart or a settings change) the picker showed only the user-configured `settings.available_models`, not the models returned by the OpenRouter API. This makes `set_api_key` refresh the models right after the key is stored, mirroring how `authenticate` already does it. ## Changes - `set_api_key` awaits the credential store and then calls `restart_fetch_models_task`, so the API model list loads immediately after a key is entered (and is cleared when the key is removed). - `fetch_models` now maps `list_models` errors via `LanguageModelCompletionError::from`, preserving the real OpenRouter error message instead of wrapping it in a generic `Other(...)`. Release Notes: - Fixed OpenRouter models not appearing until restart after adding an API key Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable ## Summary Adding an OpenRouter API key did not populate the model list until the app was restarted. `set_api_key` stored the credential but never triggered a model fetch, so until re-authentication happened (on restart or a settings change) the picker showed only the user-configured `settings.available_models`, not the models returned by the OpenRouter API. This makes `set_api_key` refresh the models right after the key is stored, mirroring how `authenticate` already does it. ## Changes - `set_api_key` awaits the credential store and then calls `restart_fetch_models_task`, so the API model list loads immediately after a key is entered (and is cleared when the key is removed). - `fetch_models` now maps `list_models` errors via `LanguageModelCompletionError::from`, preserving the real OpenRouter error message instead of wrapping it in a generic `Other(...)`. Release Notes: - Fixed OpenRouter models not appearing until restart after adding an API key Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable ## Summary Adding an OpenRouter API key did not populate the model list until the app was restarted. `set_api_key` stored the credential but never triggered a model fetch, so until re-authentication happened (on restart or a settings change) the picker showed only the user-configured `settings.available_models`, not the models returned by the OpenRouter API. This makes `set_api_key` refresh the models right after the key is stored, mirroring how `authenticate` already does it. ## Changes - `set_api_key` awaits the credential store and then calls `restart_fetch_models_task`, so the API model list loads immediately after a key is entered (and is cleared when the key is removed). - `fetch_models` now maps `list_models` errors via `LanguageModelCompletionError::from`, preserving the real OpenRouter error message instead of wrapping it in a generic `Other(...)`. Release Notes: - Fixed OpenRouter models not appearing until restart after adding an API key Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
Summary
Adding an OpenRouter API key did not populate the model list until the app was
restarted.
set_api_keystored the credential but never triggered a modelfetch, so until re-authentication happened (on restart or a settings change)
the picker showed only the user-configured
settings.available_models, not themodels returned by the OpenRouter API.
This makes
set_api_keyrefresh the models right after the key is stored,mirroring how
authenticatealready does it.Changes
set_api_keyawaits the credential store and then callsrestart_fetch_models_task, so the API model list loads immediately after akey is entered (and is cleared when the key is removed).
fetch_modelsnow mapslist_modelserrors viaLanguageModelCompletionError::from, preserving the real OpenRouter errormessage instead of wrapping it in a generic
Other(...).Release Notes: