grammars: Stop treating fish modelines as Shell Script - #58550
Merged
Conversation
bash listed fish in modeline_aliases, so a filetype=fish modeline resolved to Shell Script before the real Fish language could match by name or grammar. fish is intentionally non-POSIX, so the bash grammar is the wrong fit. Removing the alias lets fish modelines resolve to the Fish language when installed; without it they fall back to plain text rather than Shell Script.
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
MrSubidubi
approved these changes
Jun 4, 2026
yeskunall
enabled auto-merge
June 4, 2026 21:38
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
…ies#58550) Bash listed `fish` in `modeline_aliases`, so a `filetype=fish` modeline resolved to Shell Script before the real [Fish language](https://zed.dev/extensions/fish) could match by name or grammar. Fish is intentionally non-POSIX, so the Bash grammar is the wrong fit here. | Header | After | |--------|--------| | <img width="1912" height="1237" alt="image" src="https://github.com/user-attachments/assets/ed212a24-92aa-4ede-a432-47c6c6724f08" /> | <img width="1732" height="1125" alt="image" src="https://github.com/user-attachments/assets/934140b3-9473-4cca-a3e5-84aa3c4d827a" /> | Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Closes zed-industries#58532. Release Notes: - Dropped `fish` from `modeline_aliases` which forced the file to be detected as Shell Script instead of Fish
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…ies#58550) Bash listed `fish` in `modeline_aliases`, so a `filetype=fish` modeline resolved to Shell Script before the real [Fish language](https://zed.dev/extensions/fish) could match by name or grammar. Fish is intentionally non-POSIX, so the Bash grammar is the wrong fit here. | Header | After | |--------|--------| | <img width="1912" height="1237" alt="image" src="https://github.com/user-attachments/assets/ed212a24-92aa-4ede-a432-47c6c6724f08" /> | <img width="1732" height="1125" alt="image" src="https://github.com/user-attachments/assets/934140b3-9473-4cca-a3e5-84aa3c4d827a" /> | Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Closes zed-industries#58532. Release Notes: - Dropped `fish` from `modeline_aliases` which forced the file to be detected as Shell Script instead of Fish
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ies#58550) Bash listed `fish` in `modeline_aliases`, so a `filetype=fish` modeline resolved to Shell Script before the real [Fish language](https://zed.dev/extensions/fish) could match by name or grammar. Fish is intentionally non-POSIX, so the Bash grammar is the wrong fit here. | Header | After | |--------|--------| | <img width="1912" height="1237" alt="image" src="https://github.com/user-attachments/assets/ed212a24-92aa-4ede-a432-47c6c6724f08" /> | <img width="1732" height="1125" alt="image" src="https://github.com/user-attachments/assets/934140b3-9473-4cca-a3e5-84aa3c4d827a" /> | Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Closes zed-industries#58532. Release Notes: - Dropped `fish` from `modeline_aliases` which forced the file to be detected as Shell Script instead of Fish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bash listed
fishinmodeline_aliases, so afiletype=fishmodeline resolved to Shell Script before the real Fish language could match by name or grammar. Fish is intentionally non-POSIX, so the Bash grammar is the wrong fit here.Self-Review Checklist:
Closes #58532.
Release Notes:
fishfrommodeline_aliaseswhich forced the file to be detected as Shell Script instead of Fish