acp_thread: Preserve waiting tool call status on updates - #58537
Merged
Conversation
Member
Author
|
@bennetbo I dug in to the issue you were worried about and I think we are actually ok, because we replace once we send the response: zed/crates/acp_thread/src/acp_thread.rs Lines 2433 to 2450 in 6ccafcc |
Allows contents to update without dropping the permission (caused by claude subagents) Closes agentclientprotocol/claude-agent-acp#708
benbrandt
force-pushed
the
fix-permission-acp
branch
from
June 9, 2026 09:32
6ccafcc to
4791ebc
Compare
bennetbo
approved these changes
Jun 10, 2026
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…ies#58537) Allows contents to update without dropping the permission (caused by claude subagents) Closes agentclientprotocol/claude-agent-acp#708 Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - acp: Fix failed permissions requests for external agents
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ies#58537) Allows contents to update without dropping the permission (caused by claude subagents) Closes agentclientprotocol/claude-agent-acp#708 Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - acp: Fix failed permissions requests for external agents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows contents to update without dropping the permission (caused by
claude subagents)
Closes
agentclientprotocol/claude-agent-acp#708
Self-Review Checklist:
Release Notes: