tab_switcher: Select first buffer in the list when a query is enabled - #58424
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
first contribution
Contributor
Author
|
I also wanted to mention that I'm making this PR mainly because I'm an active use of the tab switcher feature and this fix is the one I'm currently using in my version Zed. |
MrSubidubi
changed the title
ChristopherBiscardi
approved these changes
Jun 4, 2026
ChristopherBiscardi
left a comment
ChristopherBiscardi
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me and behaves as expected. The logic for dealing with the query is very similar to the logic used inside of comput_selected_index when there are no matches, but the query is only accessible within the parent function so it makes sense to deal with it there.
ChristopherBiscardi
enabled auto-merge
June 4, 2026 03:01
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
…zed-industries#58424) …tered (zed-industries#58420) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#58420 Release Notes: - Reset `selected_index` to 0 whenever the query goes from empty to non-empty, ensuring the first (best) fuzzy match is always highlighted when the user starts typing. - This is handled in `update_matches()` and `update_all_pane_matches()` by checking whether the query is empty before applying the reset.
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…zed-industries#58424) …tered (zed-industries#58420) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#58420 Release Notes: - Reset `selected_index` to 0 whenever the query goes from empty to non-empty, ensuring the first (best) fuzzy match is always highlighted when the user starts typing. - This is handled in `update_matches()` and `update_all_pane_matches()` by checking whether the query is empty before applying the reset.
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…zed-industries#58424) …tered (zed-industries#58420) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#58420 Release Notes: - Reset `selected_index` to 0 whenever the query goes from empty to non-empty, ensuring the first (best) fuzzy match is always highlighted when the user starts typing. - This is handled in `update_matches()` and `update_all_pane_matches()` by checking whether the query is empty before applying the reset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tered (#58420)
Self-Review Checklist:
Closes #58420
Release Notes:
selected_indexto 0 whenever the query goes from empty to non-empty, ensuring the first (best) fuzzy match is always highlighted when the user starts typing.update_matches()andupdate_all_pane_matches()by checking whether the query is empty before applying the reset.