Skip to content

Fix panic in uncommitted_diffs_for_events - #58410

Merged
probably-neb merged 2 commits into
mainfrom
push-nsvxkmxorvmu
Jun 3, 2026
Merged

Fix panic in uncommitted_diffs_for_events#58410
probably-neb merged 2 commits into
mainfrom
push-nsvxkmxorvmu

Conversation

@Veykril

@Veykril Veykril commented Jun 3, 2026

Copy link
Copy Markdown
Member

nightly only i believe so no rel notes
Release Notes:

  • N/A or Added/Fixed/Improved ...

Veykril added 2 commits June 3, 2026 13:40
channels_with_threads opened a fresh SQLite connection per release-channel
database on every call, and the sidebar called it twice per frame from its
render path, blocking the render loop on disk I/O.

Run the per-channel checks on a background thread and cache the resulting
channel names once at sidebar construction, since the per-channel databases
cannot change while this process runs.

Release Notes:

- Improved agent panel sidebar rendering performance by no longer querying release-channel databases on every frame
@Veykril
Veykril requested a review from probably-neb June 3, 2026 11:40
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 3, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 3, 2026
@probably-neb

Copy link
Copy Markdown
Collaborator

Thanks for this!

@probably-neb
probably-neb added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main with commit 08934fa Jun 3, 2026
43 checks passed
@probably-neb
probably-neb deleted the push-nsvxkmxorvmu branch June 3, 2026 12:17
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 8, 2026
nightly only i believe so no rel notes
Release Notes:

- N/A or Added/Fixed/Improved ...
This was referenced Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
nightly only i believe so no rel notes
Release Notes:

- N/A or Added/Fixed/Improved ...
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
nightly only i believe so no rel notes
Release Notes:

- N/A or Added/Fixed/Improved ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants