Skip to content

agent_ui: Cache cross-channel thread import check off the render loop - #58402

Merged
Veykril merged 1 commit into
mainfrom
push-ykkmupqmnqup
Jun 3, 2026
Merged

agent_ui: Cache cross-channel thread import check off the render loop#58402
Veykril merged 1 commit into
mainfrom
push-ykkmupqmnqup

Conversation

@Veykril

@Veykril Veykril commented Jun 3, 2026

Copy link
Copy Markdown
Member

channels_with_threads opened a fresh SQLite connection per release-channel database on every call, and the sidebar called it twice per frame from its render path, blocking the render loop on disk I/O.

Run the per-channel checks on a background thread and cache the resulting channel names once at sidebar construction, since the per-channel databases cannot change while this process runs.

Release Notes:

  • Fixed a cause of stutters in the agent panel sidebar rendering

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 3, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 3, 2026
@Veykril
Veykril requested a review from eholk June 3, 2026 09:56
channels_with_threads opened a fresh SQLite connection per release-channel
database on every call, and the sidebar called it twice per frame from its
render path, blocking the render loop on disk I/O.

Run the per-channel checks on a background thread and cache the resulting
channel names once at sidebar construction, since the per-channel databases
cannot change while this process runs.

Release Notes:

- Improved agent panel sidebar rendering performance by no longer querying release-channel databases on every frame
@Veykril
Veykril force-pushed the push-ykkmupqmnqup branch from 13c1d01 to 1d57249 Compare June 3, 2026 11:05
@Veykril
Veykril added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main with commit 8ed0f5f Jun 3, 2026
51 of 53 checks passed
@Veykril
Veykril deleted the push-ykkmupqmnqup branch June 3, 2026 11:32
@eholk

eholk commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Thanks for catching and caching this!

TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 8, 2026
…zed-industries#58402)

channels_with_threads opened a fresh SQLite connection per
release-channel database on every call, and the sidebar called it twice
per frame from its render path, blocking the render loop on disk I/O.

Run the per-channel checks on a background thread and cache the
resulting channel names once at sidebar construction, since the
per-channel databases cannot change while this process runs.

Release Notes:

- Fixed a cause of stutters in the agent panel sidebar rendering
This was referenced Jun 18, 2026
liusuren123 pushed a commit to liusuren123/zed that referenced this pull request Jun 24, 2026
…zed-industries#58402)

channels_with_threads opened a fresh SQLite connection per
release-channel database on every call, and the sidebar called it twice
per frame from its render path, blocking the render loop on disk I/O.

Run the per-channel checks on a background thread and cache the
resulting channel names once at sidebar construction, since the
per-channel databases cannot change while this process runs.

Release Notes:

- Fixed a cause of stutters in the agent panel sidebar rendering
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…zed-industries#58402)

channels_with_threads opened a fresh SQLite connection per
release-channel database on every call, and the sidebar called it twice
per frame from its render path, blocking the render loop on disk I/O.

Run the per-channel checks on a background thread and cache the
resulting channel names once at sidebar construction, since the
per-channel databases cannot change while this process runs.

Release Notes:

- Fixed a cause of stutters in the agent panel sidebar rendering
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…zed-industries#58402)

channels_with_threads opened a fresh SQLite connection per
release-channel database on every call, and the sidebar called it twice
per frame from its render path, blocking the render loop on disk I/O.

Run the per-channel checks on a background thread and cache the
resulting channel names once at sidebar construction, since the
per-channel databases cannot change while this process runs.

Release Notes:

- Fixed a cause of stutters in the agent panel sidebar rendering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants