workspace: Update window title when switching active workspace - #58401
Merged
Conversation
In a multi-workspace window several workspaces share one platform window. Switching the active workspace did not update the window title or edited indicator, and background workspaces could clobber the active workspace's title via their still-live project/item event subscriptions. Track the active workspace id in a shared Rc<Cell<EntityId>> owned by the MultiWorkspace and read by each member workspace, so a workspace only writes the shared window's title/edited state when it is the active one. Reading the cell never leases an entity, so the gate is safe from any context. The newly active workspace re-applies its title and edited indicator on activation. Release Notes: - Fixed the window title not updating when switching between workspaces in a multi-workspace window
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
eholk
reviewed
Jun 5, 2026
eholk
reviewed
Jun 5, 2026
eholk
approved these changes
Jun 5, 2026
Contributor
|
Thanks for fixing this! I made a couple doc comment suggestions but it's up to you whether you want to take them or not. |
Co-authored-by: Eric Holk <eric@theincredibleholk.org>
Veykril
enabled auto-merge
June 5, 2026 18:56
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
…ndustries#58401) In a multi-workspace window several workspaces share one platform window. Switching the active workspace did not update the window title or edited indicator, and background workspaces could clobber the active workspace's title via their still-live project/item event subscriptions. Track the active workspace id in a shared Rc<Cell<EntityId>> owned by the MultiWorkspace and read by each member workspace, so a workspace only writes the shared window's title/edited state when it is the active one. The newly active workspace re-applies its title and edited indicator on activation. We use a Rc-cell here to avoid double lease issues as we cannot tell whether we are inside a running MultiWorkspace lease or not in the given codepaths. Release Notes: - Fixed the window title not updating when switching between workspaces in a multi-workspace window --------- Co-authored-by: Eric Holk <eric@theincredibleholk.org>
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…ndustries#58401) In a multi-workspace window several workspaces share one platform window. Switching the active workspace did not update the window title or edited indicator, and background workspaces could clobber the active workspace's title via their still-live project/item event subscriptions. Track the active workspace id in a shared Rc<Cell<EntityId>> owned by the MultiWorkspace and read by each member workspace, so a workspace only writes the shared window's title/edited state when it is the active one. The newly active workspace re-applies its title and edited indicator on activation. We use a Rc-cell here to avoid double lease issues as we cannot tell whether we are inside a running MultiWorkspace lease or not in the given codepaths. Release Notes: - Fixed the window title not updating when switching between workspaces in a multi-workspace window --------- Co-authored-by: Eric Holk <eric@theincredibleholk.org>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ndustries#58401) In a multi-workspace window several workspaces share one platform window. Switching the active workspace did not update the window title or edited indicator, and background workspaces could clobber the active workspace's title via their still-live project/item event subscriptions. Track the active workspace id in a shared Rc<Cell<EntityId>> owned by the MultiWorkspace and read by each member workspace, so a workspace only writes the shared window's title/edited state when it is the active one. The newly active workspace re-applies its title and edited indicator on activation. We use a Rc-cell here to avoid double lease issues as we cannot tell whether we are inside a running MultiWorkspace lease or not in the given codepaths. Release Notes: - Fixed the window title not updating when switching between workspaces in a multi-workspace window --------- Co-authored-by: Eric Holk <eric@theincredibleholk.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a multi-workspace window several workspaces share one platform window. Switching the active workspace did not update the window title or edited indicator, and background workspaces could clobber the active workspace's title via their still-live project/item event subscriptions.
Track the active workspace id in a shared Rc<Cell> owned by the MultiWorkspace and read by each member workspace, so a workspace only writes the shared window's title/edited state when it is the active one. The newly active workspace re-applies its title and edited indicator on activation. We use a Rc-cell here to avoid double lease issues as we cannot tell whether we are inside a running MultiWorkspace lease or not in the given codepaths.
Release Notes: