Skip to content

Fix external tool call locations - #58367

Merged
MartinYe1234 merged 1 commit into
mainfrom
martin/ai-362-go-to-file-on-global-skills-does-not-work-in-agent
Jun 3, 2026
Merged

Fix external tool call locations#58367
MartinYe1234 merged 1 commit into
mainfrom
martin/ai-362-go-to-file-on-global-skills-does-not-work-in-agent

Conversation

@MartinYe1234

@MartinYe1234 MartinYe1234 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Allow agent tool-call locations outside visible worktrees to resolve as local buffers.
  • Fall back to opening absolute paths from the tool-call click handler.

Tests:

  • cargo test -p acp_thread test_tool_call_location_resolves_external_file
  • cargo check -p agent_ui

Closes AI-362
Release Notes:

  • Fixed opening agent-created files outside the current project, such as global skill files.

@MartinYe1234 MartinYe1234 self-assigned this Jun 2, 2026
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 2, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 2, 2026
@MartinYe1234
MartinYe1234 marked this pull request as ready for review June 2, 2026 22:28
@MartinYe1234
MartinYe1234 added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main with commit 6014f59 Jun 3, 2026
44 checks passed
@MartinYe1234
MartinYe1234 deleted the martin/ai-362-go-to-file-on-global-skills-does-not-work-in-agent branch June 3, 2026 19:50
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 8, 2026
Summary:

- Allow agent tool-call locations outside visible worktrees to resolve
as local buffers.
- Fall back to opening absolute paths from the tool-call click handler.

Tests:

- cargo test -p acp_thread
test_tool_call_location_resolves_external_file
- cargo check -p agent_ui

Closes AI-362
Release Notes:

- Fixed opening agent-created files outside the current project, such as
global skill files.
This was referenced Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
Summary:

- Allow agent tool-call locations outside visible worktrees to resolve
as local buffers.
- Fall back to opening absolute paths from the tool-call click handler.

Tests:

- cargo test -p acp_thread
test_tool_call_location_resolves_external_file
- cargo check -p agent_ui

Closes AI-362
Release Notes:

- Fixed opening agent-created files outside the current project, such as
global skill files.
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
Summary:

- Allow agent tool-call locations outside visible worktrees to resolve
as local buffers.
- Fall back to opening absolute paths from the tool-call click handler.

Tests:

- cargo test -p acp_thread
test_tool_call_location_resolves_external_file
- cargo check -p agent_ui

Closes AI-362
Release Notes:

- Fixed opening agent-created files outside the current project, such as
global skill files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants