agent: Warn about long skill descriptions - #58356
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
anantdgoel
marked this pull request as draft
June 2, 2026 19:13
zed-community-bot
Bot
added
the
staff
Co-authored-by: Martin Ye <martin@zed.dev>
- Introduce CompletionDocumentation::WarningAndMultiLinePlainText - Render warnings alongside completion text and adjust size calculations - Refactor skill issue rows to a file-centric layout with icons and tooltips - Add file-open behavior on clicking skill issue rows - Use uri-based icons for skill completion paths - Update skill completion docs to use the new warning variant - Move skill loading UI placement within ThreadView - Extend LSP store display logic to support the new warning variant Co-authored-by: Martin Ye <martin@zed.dev>
Co-authored-by: Martin Ye <martin@zed.dev>
anantdgoel
marked this pull request as ready for review
June 5, 2026 15:37
MartinYe1234
approved these changes
Jun 5, 2026
anantdgoel
enabled auto-merge
June 5, 2026 19:36
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
Closes zed-industries#58046 Closes AI-353 Skills with descriptions over the 1024-byte limit now load with a warning instead of failing. The warning appears in the thread footer with clickable skill file rows, and the skill picker keeps the skill icon while showing a right-aligned warning badge whose hover text explains the issue. Warning for single out-of-spec skill <img width="2790" height="870" alt="image" src="https://github.com/user-attachments/assets/f454b55a-8e05-438e-b4ff-356259ff6843" /> Warning for multiple out-of-spec skills <img width="2796" height="646" alt="image" src="https://github.com/user-attachments/assets/a0808cdd-4857-4a6b-a26e-15156afbffe9" /> Skill selection popup <img width="1234" height="1118" alt="image" src="https://github.com/user-attachments/assets/5bb463f6-7adb-4e39-8522-e322bf078aff" /> Skill management in settings <img width="1768" height="1390" alt="image" src="https://github.com/user-attachments/assets/85c6b179-e268-4518-8ca7-c73b55f92355" /> Release Notes: - Allow loading skills whose descriptions exceed the 1024-byte limit by showing warnings instead of failing to load them. --------- Co-authored-by: Martin Ye <martin@zed.dev> Co-authored-by: zed-zippy[bot] <234243425+zed-zippy[bot]@users.noreply.github.com>
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Closes zed-industries#58046 Closes AI-353 Skills with descriptions over the 1024-byte limit now load with a warning instead of failing. The warning appears in the thread footer with clickable skill file rows, and the skill picker keeps the skill icon while showing a right-aligned warning badge whose hover text explains the issue. Warning for single out-of-spec skill <img width="2790" height="870" alt="image" src="https://github.com/user-attachments/assets/f454b55a-8e05-438e-b4ff-356259ff6843" /> Warning for multiple out-of-spec skills <img width="2796" height="646" alt="image" src="https://github.com/user-attachments/assets/a0808cdd-4857-4a6b-a26e-15156afbffe9" /> Skill selection popup <img width="1234" height="1118" alt="image" src="https://github.com/user-attachments/assets/5bb463f6-7adb-4e39-8522-e322bf078aff" /> Skill management in settings <img width="1768" height="1390" alt="image" src="https://github.com/user-attachments/assets/85c6b179-e268-4518-8ca7-c73b55f92355" /> Release Notes: - Allow loading skills whose descriptions exceed the 1024-byte limit by showing warnings instead of failing to load them. --------- Co-authored-by: Martin Ye <martin@zed.dev> Co-authored-by: zed-zippy[bot] <234243425+zed-zippy[bot]@users.noreply.github.com>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Closes zed-industries#58046 Closes AI-353 Skills with descriptions over the 1024-byte limit now load with a warning instead of failing. The warning appears in the thread footer with clickable skill file rows, and the skill picker keeps the skill icon while showing a right-aligned warning badge whose hover text explains the issue. Warning for single out-of-spec skill <img width="2790" height="870" alt="image" src="https://github.com/user-attachments/assets/f454b55a-8e05-438e-b4ff-356259ff6843" /> Warning for multiple out-of-spec skills <img width="2796" height="646" alt="image" src="https://github.com/user-attachments/assets/a0808cdd-4857-4a6b-a26e-15156afbffe9" /> Skill selection popup <img width="1234" height="1118" alt="image" src="https://github.com/user-attachments/assets/5bb463f6-7adb-4e39-8522-e322bf078aff" /> Skill management in settings <img width="1768" height="1390" alt="image" src="https://github.com/user-attachments/assets/85c6b179-e268-4518-8ca7-c73b55f92355" /> Release Notes: - Allow loading skills whose descriptions exceed the 1024-byte limit by showing warnings instead of failing to load them. --------- Co-authored-by: Martin Ye <martin@zed.dev> Co-authored-by: zed-zippy[bot] <234243425+zed-zippy[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58046
Closes AI-353
Skills with descriptions over the 1024-byte limit now load with a warning instead of failing. The warning appears in the thread footer with clickable skill file rows, and the skill picker keeps the skill icon while showing a right-aligned warning badge whose hover text explains the issue.
Warning for single out-of-spec skill
Warning for multiple out-of-spec skills
Skill selection popup
Skill management in settings
Release Notes: