Skip to content

git_ui: Render commit message as markdown - #58274

Merged
danilo-leal merged 2 commits into
mainfrom
commit-view-commit
Jun 1, 2026
Merged

git_ui: Render commit message as markdown#58274
danilo-leal merged 2 commits into
mainfrom
commit-view-commit

Conversation

@danilo-leal

Copy link
Copy Markdown
Member

This PR removes the commit message from the first excerpt of the multibuffer and renders it as markdown in the commit view's header. Effectively, this allows the commit view to use the split diff buffer, as done in #58163.

Screenshot 2026-06-01 at 6  34@2x

Release Notes:

  • N/A

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 1, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 1, 2026

@Anthony-Eid Anthony-Eid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but is the commit block going to be searchable still?

@danilo-leal
danilo-leal added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit b764e5e Jun 1, 2026
43 checks passed
@danilo-leal
danilo-leal deleted the commit-view-commit branch June 1, 2026 22:22
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
This PR removes the commit message from the first excerpt of the
multibuffer and renders it as markdown in the commit view's header.
Effectively, this allows the commit view to use the split diff buffer,
as done in zed-industries#58163.

<img width="600" alt="Screenshot 2026-06-01 at 6  34@2x"
src="https://github.com/user-attachments/assets/a763a04d-88ce-4d29-9cee-872a33ace6e4"
/>

Release Notes:

- N/A
github-actions Bot pushed a commit to msathis/zed that referenced this pull request Jun 2, 2026
Follow up to zed-industries#58274 — this PR
limits the height of the commit description in the header so that it
doesn't grow indefinitely pushing the diff multibuffer out of view.

Release Notes:

- N/A
dandv pushed a commit to dandv/zed that referenced this pull request Jun 3, 2026
Follow up to zed-industries#58274 — this PR
limits the height of the commit description in the header so that it
doesn't grow indefinitely pushing the diff multibuffer out of view.

Release Notes:

- N/A
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 8, 2026
Follow up to zed-industries#58274 — this PR
limits the height of the commit description in the header so that it
doesn't grow indefinitely pushing the diff multibuffer out of view.

Release Notes:

- N/A
This was referenced Jun 18, 2026
@nguyenphutrong

Copy link
Copy Markdown
Contributor

Hi @danilo-leal @Anthony-Eid

I noticed a regression from this change: rendering commit messages through the full Markdown parser applies smart punctuation, so messages like Merge branch 'feature/foo' into develop display as Merge branch ‘feature/foo’ into develop.

Since commit messages should be shown verbatim, this probably needs Markdown::new_text(...) or another mode that preserves raw ASCII punctuation while still allowing link detection.

jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
This PR removes the commit message from the first excerpt of the
multibuffer and renders it as markdown in the commit view's header.
Effectively, this allows the commit view to use the split diff buffer,
as done in zed-industries#58163.

<img width="600" alt="Screenshot 2026-06-01 at 6  34@2x"
src="https://github.com/user-attachments/assets/a763a04d-88ce-4d29-9cee-872a33ace6e4"
/>

Release Notes:

- N/A
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
Follow up to zed-industries#58274 — this PR
limits the height of the commit description in the header so that it
doesn't grow indefinitely pushing the diff multibuffer out of view.

Release Notes:

- N/A
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
This PR removes the commit message from the first excerpt of the
multibuffer and renders it as markdown in the commit view's header.
Effectively, this allows the commit view to use the split diff buffer,
as done in zed-industries#58163.

<img width="600" alt="Screenshot 2026-06-01 at 6  34@2x"
src="https://github.com/user-attachments/assets/a763a04d-88ce-4d29-9cee-872a33ace6e4"
/>

Release Notes:

- N/A
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
Follow up to zed-industries#58274 — this PR
limits the height of the commit description in the header so that it
doesn't grow indefinitely pushing the diff multibuffer out of view.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants