Skip to content

extension_api: Remove x86 support - #58259

Merged
MrSubidubi merged 2 commits into
mainfrom
remove-x86
Jun 4, 2026
Merged

extension_api: Remove x86 support#58259
MrSubidubi merged 2 commits into
mainfrom
remove-x86

Conversation

@MrSubidubi

@MrSubidubi MrSubidubi commented Jun 1, 2026

Copy link
Copy Markdown
Member

This PR drops the Architecture::x86 variant within the extension API.

Reason for this being that

  • Zed itself is not shipped for 32 bit and thus this variant is never actually constructed
  • we don't support a Node runtime in 32 bit environments
  • basically all language and context servers do not ship 32 bit variants

Thus, this PR removes support for this variant, as currently, extension authors always have to return an error for the missing 32 bit support of their binaries. With this, this will no longer be needed.

Lastly, this removes one space of too much indentation I found whilst doing these changes. Very visible in the GitHub UI luckily.

Release Notes:

  • Removed support for extensions downloading language servers, debuggers and MCP servers on 32-bit architecture. Extensions may still work if you manually specify a path to an appropriate binary, but will not succeed when attempting to download a binary based on the current systems 32-bit architecture.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 1, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 1, 2026
@maxdeviant

Copy link
Copy Markdown
Member

Release Notes:

  • zed_extension_api::current_platform will no longer return Architecture::X86 starting with the next version of the Zed extension API (v0.8.0). This variant would previously never be passed and is now officially unsupported.

I think we can omit from release notes, as it's not really a user-facing change (in terms of people using Zed).

@MrSubidubi
MrSubidubi added this pull request to the merge queue Jun 4, 2026
Merged via the queue into main with commit 5366733 Jun 4, 2026
38 checks passed
@MrSubidubi
MrSubidubi deleted the remove-x86 branch June 4, 2026 11:06
@zed-zippy zed-zippy Bot added the PR state:needs review Used to label PRs that are in need of a post-merge approval label Jun 4, 2026
@maxdeviant

Copy link
Copy Markdown
Member

@zed-industries/approved

@zed-zippy zed-zippy Bot removed the PR state:needs review Used to label PRs that are in need of a post-merge approval label Jun 4, 2026
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 8, 2026
This PR drops the `Architecture::x86` variant within the extension API. 

Reason for this being that 
- Zed itself is not shipped for 32 bit and thus this variant is never
actually constructed
- we don't support a Node runtime in 32 bit environments
- basically all language and context servers do not ship 32 bit variants

Thus, this PR removes support for this variant, as currently, extension
authors always have to return an error for the missing 32 bit support of
their binaries. With this, this will no longer be needed.

Lastly, this removes one space of too much indentation I found whilst
doing these changes. Very visible in the GitHub UI luckily.

Release Notes:

- Removed support for extensions downloading language servers, debuggers
and MCP servers on 32-bit architecture. Extensions may still work if you
manually specify a path to an appropriate binary, but will not succeed
when attempting to download a binary based on the current systems 32-bit
architecture.
This was referenced Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
This PR drops the `Architecture::x86` variant within the extension API. 

Reason for this being that 
- Zed itself is not shipped for 32 bit and thus this variant is never
actually constructed
- we don't support a Node runtime in 32 bit environments
- basically all language and context servers do not ship 32 bit variants

Thus, this PR removes support for this variant, as currently, extension
authors always have to return an error for the missing 32 bit support of
their binaries. With this, this will no longer be needed.

Lastly, this removes one space of too much indentation I found whilst
doing these changes. Very visible in the GitHub UI luckily.

Release Notes:

- Removed support for extensions downloading language servers, debuggers
and MCP servers on 32-bit architecture. Extensions may still work if you
manually specify a path to an appropriate binary, but will not succeed
when attempting to download a binary based on the current systems 32-bit
architecture.
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
This PR drops the `Architecture::x86` variant within the extension API. 

Reason for this being that 
- Zed itself is not shipped for 32 bit and thus this variant is never
actually constructed
- we don't support a Node runtime in 32 bit environments
- basically all language and context servers do not ship 32 bit variants

Thus, this PR removes support for this variant, as currently, extension
authors always have to return an error for the missing 32 bit support of
their binaries. With this, this will no longer be needed.

Lastly, this removes one space of too much indentation I found whilst
doing these changes. Very visible in the GitHub UI luckily.

Release Notes:

- Removed support for extensions downloading language servers, debuggers
and MCP servers on 32-bit architecture. Extensions may still work if you
manually specify a path to an appropriate binary, but will not succeed
when attempting to download a binary based on the current systems 32-bit
architecture.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants