extension_api: Remove x86 support - #58259
Merged
Merged
Conversation
Member
I think we can omit from release notes, as it's not really a user-facing change (in terms of people using Zed). |
Member
|
@zed-industries/approved |
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
This PR drops the `Architecture::x86` variant within the extension API. Reason for this being that - Zed itself is not shipped for 32 bit and thus this variant is never actually constructed - we don't support a Node runtime in 32 bit environments - basically all language and context servers do not ship 32 bit variants Thus, this PR removes support for this variant, as currently, extension authors always have to return an error for the missing 32 bit support of their binaries. With this, this will no longer be needed. Lastly, this removes one space of too much indentation I found whilst doing these changes. Very visible in the GitHub UI luckily. Release Notes: - Removed support for extensions downloading language servers, debuggers and MCP servers on 32-bit architecture. Extensions may still work if you manually specify a path to an appropriate binary, but will not succeed when attempting to download a binary based on the current systems 32-bit architecture.
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
This PR drops the `Architecture::x86` variant within the extension API. Reason for this being that - Zed itself is not shipped for 32 bit and thus this variant is never actually constructed - we don't support a Node runtime in 32 bit environments - basically all language and context servers do not ship 32 bit variants Thus, this PR removes support for this variant, as currently, extension authors always have to return an error for the missing 32 bit support of their binaries. With this, this will no longer be needed. Lastly, this removes one space of too much indentation I found whilst doing these changes. Very visible in the GitHub UI luckily. Release Notes: - Removed support for extensions downloading language servers, debuggers and MCP servers on 32-bit architecture. Extensions may still work if you manually specify a path to an appropriate binary, but will not succeed when attempting to download a binary based on the current systems 32-bit architecture.
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
This PR drops the `Architecture::x86` variant within the extension API. Reason for this being that - Zed itself is not shipped for 32 bit and thus this variant is never actually constructed - we don't support a Node runtime in 32 bit environments - basically all language and context servers do not ship 32 bit variants Thus, this PR removes support for this variant, as currently, extension authors always have to return an error for the missing 32 bit support of their binaries. With this, this will no longer be needed. Lastly, this removes one space of too much indentation I found whilst doing these changes. Very visible in the GitHub UI luckily. Release Notes: - Removed support for extensions downloading language servers, debuggers and MCP servers on 32-bit architecture. Extensions may still work if you manually specify a path to an appropriate binary, but will not succeed when attempting to download a binary based on the current systems 32-bit architecture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR drops the
Architecture::x86variant within the extension API.Reason for this being that
Thus, this PR removes support for this variant, as currently, extension authors always have to return an error for the missing 32 bit support of their binaries. With this, this will no longer be needed.
Lastly, this removes one space of too much indentation I found whilst doing these changes. Very visible in the GitHub UI luckily.
Release Notes: