agent_ui: Restore hover previews for image mentions - #58165
Merged
danilo-leal merged 1 commit intoJun 2, 2026
Conversation
cla-bot
Bot
added
the
cla-signed
danilo-leal
enabled auto-merge
June 2, 2026 23:22
dandv
pushed a commit
to dandv/zed
that referenced
this pull request
Jun 3, 2026
…8165) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#58153 Release Notes: - Agent: Fixed image previews not being displayed after submitting a prompt and then hovering the mentioned image.
5 tasks
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
…8165) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#58153 Release Notes: - Agent: Fixed image previews not being displayed after submitting a prompt and then hovering the mentioned image.
dandv
added a commit
to dandv/zed
that referenced
this pull request
Jun 9, 2026
Builds on the merged hover-preview work (zed-industries#58165). That change shows a small thumbnail on hover, but large screenshots are unreadable at that size. Clicking a pasted-image chip now materializes the image to a file and opens it full-size in an editor tab. Pasted images only exist as in-memory data, so the file is written under the Zed data directory (not the OS temp dir) so it survives Zed restarts and OS reboots, letting an open pasted-image tab be restored faithfully. When the tab is closed, the editor entity is released and the file is deleted - unless the app is quitting, in which case it is kept so the tab can be restored on the next launch. The handler is wired both for freshly pasted images and for images in restored thread messages. File-attached images already open via their on-disk path, so they are unaffected. Also tidies the hover-preview decode helper from zed-industries#58165 to use the codebase-standard `.log_err()` and return `Option<Arc<Image>>` instead of a nested `Shared<Task<...>>`. Release Notes: - Improved pasted images in the agent panel: clicking a pasted-image chip now opens the image full-size in an editor tab.
This was referenced Jun 10, 2026
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…8165) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#58153 Release Notes: - Agent: Fixed image previews not being displayed after submitting a prompt and then hovering the mentioned image.
dandv
added a commit
to dandv/zed
that referenced
this pull request
Jul 29, 2026
Builds on the merged hover-preview work (zed-industries#58165). That change shows a small thumbnail on hover, but large screenshots are unreadable at that size. Clicking a pasted-image chip now materializes the image to a file and opens it full-size in an editor tab. Pasted images only exist as in-memory data, so the file is written under the Zed data directory (not the OS temp dir) so it survives Zed restarts and OS reboots, letting an open pasted-image tab be restored faithfully. When the tab is closed, the editor entity is released and the file is deleted - unless the app is quitting, in which case it is kept so the tab can be restored on the next launch. The handler is wired both for freshly pasted images and for images in restored thread messages. File-attached images already open via their on-disk path, so they are unaffected. Also tidies the hover-preview decode helper from zed-industries#58165 to use the codebase-standard `.log_err()` and return `Option<Arc<Image>>` instead of a nested `Shared<Task<...>>`. Release Notes: - Improved pasted images in the agent panel: clicking a pasted-image chip now opens the image full-size in an editor tab.
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…8165) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#58153 Release Notes: - Agent: Fixed image previews not being displayed after submitting a prompt and then hovering the mentioned image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
Closes #58153
Release Notes: