git_ui: Trim surrounding whitespace from new branch names - #58151
Merged
Conversation
Closes zed-industries#56602. Creating a branch from the branch picker normalizes the typed name with `replace(' ', "-")`, so leading or trailing spaces became leading or trailing hyphens (e.g. ` fix-leak ` -> `-fix-leak-`). git rejects such names, so branch creation failed. Trimming the query before replacing spaces yields a valid name. Release Notes: - git_ui: Fixed branch creation failing when a branch name had leading or trailing whitespace
cla-bot
Bot
added
the
cla-signed
Contributor
Author
|
Thanks for the review and the cleanup, @dinocosta! 🙏 |
This was referenced Jun 10, 2026
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…ries#58151) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#56602. Creating a branch from the branch picker normalizes the typed name with `replace(' ', "-")`, so leading or trailing spaces became leading or trailing hyphens (e.g. ` fix-leak ` -> `-fix-leak-`). git rejects such names, so branch creation failed. Trimming the query before replacing spaces yields a valid name. Release Notes: - git_ui: Fixed branch creation failing when a branch name had leading or trailing whitespace --------- Co-authored-by: dino <dinojoaocosta@gmail.com>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ries#58151) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#56602. Creating a branch from the branch picker normalizes the typed name with `replace(' ', "-")`, so leading or trailing spaces became leading or trailing hyphens (e.g. ` fix-leak ` -> `-fix-leak-`). git rejects such names, so branch creation failed. Trimming the query before replacing spaces yields a valid name. Release Notes: - git_ui: Fixed branch creation failing when a branch name had leading or trailing whitespace --------- Co-authored-by: dino <dinojoaocosta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
Closes #56602.
Creating a branch from the branch picker normalizes the typed name with
replace(' ', "-"), so leading or trailing spaces became leading or trailing hyphens (e.g.fix-leak->-fix-leak-). git rejects such names, so branch creation failed.Trimming the query before replacing spaces yields a valid name.
Release Notes: