Recognize shell-script as shell in modelines - #58124
Merged
dinocosta merged 1 commit intoJun 1, 2026
Merged
Conversation
shell-script-mode is a valid and commonly used alias for sh-mode in Emacs. Release Notes: - Recognize shell-script as shell in Emacs modelines.
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
first contribution
scop
added a commit
to scop/bash-completion
that referenced
this pull request
Jun 1, 2026
In particular, remove them from files with names containing a typical extension for a language. These should be unnecessary at best, but an unknown mode or alias can also prevent a file from being opened with the correct mode. This is what happens currently with Zed 1.4.4, ref zed-industries/zed#58124
scop
added a commit
to scop/bash-completion
that referenced
this pull request
Jun 1, 2026
In particular, remove them from files with names containing a typical extension for a language. These should be unnecessary at best, but an unknown mode or alias can also prevent a file from being opened with the correct mode. This is what happens currently with Zed 1.4.4, ref zed-industries/zed#58124
dinocosta
enabled auto-merge
June 1, 2026 19:23
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
shell-script-mode is a valid and commonly used alias for sh-mode in Emacs. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes N/A Release Notes: - Added support for `shell-script` filetype in Vim modelines
This was referenced Jun 10, 2026
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
shell-script-mode is a valid and commonly used alias for sh-mode in Emacs. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes N/A Release Notes: - Added support for `shell-script` filetype in Vim modelines
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
shell-script-mode is a valid and commonly used alias for sh-mode in Emacs. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes N/A Release Notes: - Added support for `shell-script` filetype in Vim modelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shell-script-mode is a valid and commonly used alias for sh-mode in Emacs.
Self-Review Checklist:
Closes N/A
Release Notes:
shell-scriptfiletype in Vim modelines