Skip to content

Support ex: in vim modelines - #58121

Merged
dinocosta merged 3 commits into
zed-industries:mainfrom
scop:feat/vim-modeline-ex
Jun 1, 2026
Merged

Support ex: in vim modelines#58121
dinocosta merged 3 commits into
zed-industries:mainfrom
scop:feat/vim-modeline-ex

Conversation

@scop

@scop scop commented May 30, 2026

Copy link
Copy Markdown
Contributor

Ref https://vimdoc.sourceforge.net/htmldoc/options.html#ex%3A

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes N/A

Release Notes:

  • Support ex: identifier in vim modelines.

@cla-bot

cla-bot Bot commented May 30, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @scop on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label May 30, 2026
Ref https://vimdoc.sourceforge.net/htmldoc/options.html#ex%3A

Release Notes:

- Support ex: identifier in vim modelines.
@scop
scop force-pushed the feat/vim-modeline-ex branch from 4a55686 to 15e2560 Compare May 30, 2026 08:49
@cla-bot

cla-bot Bot commented May 30, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @scop on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@scop

scop commented May 30, 2026

Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 30, 2026
@cla-bot

cla-bot Bot commented May 30, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@dinocosta dinocosta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @scop ! Pushed a smaller commit to ensure that whitespace is required before ex: to follow vim's spec 🫡

@dinocosta
dinocosta enabled auto-merge June 1, 2026 18:45
@dinocosta dinocosta added the area:parity/vim Feedback for Vim parity features label Jun 1, 2026
@dinocosta dinocosta self-assigned this Jun 1, 2026
@dinocosta
dinocosta added this pull request to the merge queue Jun 1, 2026
Merged via the queue into zed-industries:main with commit beedd3e Jun 1, 2026
43 checks passed
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
Ref https://vimdoc.sourceforge.net/htmldoc/options.html#ex%3A

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [ ] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes N/A

Release Notes:

- Support `ex:` identifier in vim modelines.

---------

Co-authored-by: dino <dinojoaocosta@gmail.com>
@scop
scop deleted the feat/vim-modeline-ex branch June 2, 2026 19:29
This was referenced Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
Ref https://vimdoc.sourceforge.net/htmldoc/options.html#ex%3A

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [ ] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes N/A

Release Notes:

- Support `ex:` identifier in vim modelines.

---------

Co-authored-by: dino <dinojoaocosta@gmail.com>
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
Ref https://vimdoc.sourceforge.net/htmldoc/options.html#ex%3A

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [ ] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes N/A

Release Notes:

- Support `ex:` identifier in vim modelines.

---------

Co-authored-by: dino <dinojoaocosta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:parity/vim Feedback for Vim parity features cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants