Skip to content

Use correct provider icons for extension repository links - #58108

Merged
danilo-leal merged 4 commits into
zed-industries:mainfrom
albertbogusz:more-extension-repo-icons
Aug 4, 2026
Merged

Use correct provider icons for extension repository links#58108
danilo-leal merged 4 commits into
zed-industries:mainfrom
albertbogusz:more-extension-repo-icons

Conversation

@albertbogusz

@albertbogusz albertbogusz commented May 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments (N/A)
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

I was unable to find an issue or PR which mentions this.

Extensions with non-GitHub repository links always use the GitHub icon, which is inconsistent with the changes merged in #44738 and #57500. This change makes extension_ui.rs use the Git hosting provider registry to determine these icons. Below is a preview of the change:

Preview

Release Notes:

  • Improved extension repository links to show provider-specific icons.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 30, 2026
maxdeviant
maxdeviant reviewed May 30, 2026
View reviewed changes
Comment thread crates/extensions_ui/Cargo.toml Outdated
@albertbogusz

albertbogusz commented May 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

I removed the git_ui dependency to instead use local provider matching instead. I don't love the code duplication from get_provider_icons in git_ui so more than happy to extract it somewhere shared git_graph, commit_view and extension_ui could all use. There also is the option to just reduce the icons we match for here as the extension registry (currently) only has repo links to GitHub, GitLab, Codeberg, and other links that fallback to the generic link icon anyway - obviously for future-proofing sakes this wouldn't be ideal.

@albertbogusz
albertbogusz requested a review from maxdeviant May 30, 2026 01:52
@dinocosta dinocosta added the area:extensions/infrastructure Feedback for extensions APIs, creation, management, etc label Jun 1, 2026
@albertbogusz

albertbogusz commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Scrapped the duplicated matching. Moved the provider name matching into the more appropriate ui/src/components/icon.rs for extensions_ui, commit_view and git_graph to all use.

@albertbogusz
albertbogusz force-pushed the more-extension-repo-icons branch from 277a48a to c45dc9d Compare July 22, 2026 18:39
@albertbogusz
albertbogusz force-pushed the more-extension-repo-icons branch from ebc7cd1 to e1104b8 Compare August 3, 2026 23:41
@albertbogusz
albertbogusz force-pushed the more-extension-repo-icons branch from e1104b8 to 426aa2d Compare August 3, 2026 23:53
@albertbogusz albertbogusz changed the title Use correct provider icons and consistent tooltips for extension repository links Use correct provider icons for extension repository links Aug 4, 2026
@albertbogusz

albertbogusz commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

The consistent tooltips seem to have been already fixed in #61850, so removed that from title and desc

danilo-leal
danilo-leal approved these changes Aug 4, 2026
View reviewed changes

@danilo-leal danilo-leal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you so much!

@danilo-leal
danilo-leal added this pull request to the merge queue Aug 4, 2026
Merged via the queue into zed-industries:main with commit b8c75f1 Aug 4, 2026
36 checks passed
@albertbogusz
albertbogusz deleted the more-extension-repo-icons branch August 4, 2026 15:25
player1537 pushed a commit to player1537-forks/zed that referenced this pull request Aug 9, 2026
@albertbogusz @player1537
Use correct provider icons for extension repository links (zed-indust…
0cb6ff4 
…ries#58108)

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments (N/A)
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

I was unable to find an issue or PR which mentions this.

Extensions with non-GitHub repository links always use the GitHub icon,
which is inconsistent with the changes merged in zed-industries#44738 and zed-industries#57500. This
change makes `extension_ui.rs` use the Git hosting provider registry to
determine these icons. Below is a preview of the change:

<div align="center">
    <img
        width="450"
        alt="Preview"

src="https://github.com/user-attachments/assets/e35f0eed-de54-48f9-824d-8a5b9bfc596f"
    />
</div>

Release Notes:

- Improved extension repository links to show provider-specific icons.
audivir pushed a commit to audivir/zed that referenced this pull request Aug 10, 2026
@albertbogusz
Use correct provider icons for extension repository links (zed-indust…
c7be69a 
…ries#58108)

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments (N/A)
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

I was unable to find an issue or PR which mentions this.

Extensions with non-GitHub repository links always use the GitHub icon,
which is inconsistent with the changes merged in zed-industries#44738 and zed-industries#57500. This
change makes `extension_ui.rs` use the Git hosting provider registry to
determine these icons. Below is a preview of the change:

<div align="center">
    <img
        width="450"
        alt="Preview"

src="https://github.com/user-attachments/assets/e35f0eed-de54-48f9-824d-8a5b9bfc596f"
    />
</div>

Release Notes:

- Improved extension repository links to show provider-specific icons.
@github-actions github-actions Bot mentioned this pull request Aug 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes
@maxdeviant maxdeviant Awaiting requested review from maxdeviant

Assignees

@maxdeviant maxdeviant

@danilo-leal danilo-leal

Labels

area:extensions/infrastructure Feedback for extensions APIs, creation, management, etc cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@albertbogusz @maxdeviant @danilo-leal @dinocosta