vim: Increment date segments independently in Helix mode - #58098
Closed
jgarte wants to merge 1 commit into
Closed
Conversation
In Helix mode, ctrl-a/ctrl-x on a date like 2024-01-15 always incremented the year regardless of cursor position, because the backward scan treated the hyphen as a negative sign and walked back to the first segment. Treat a hyphen that separates two numbers (preceded by a digit) as a boundary in Helix mode so the segment under the cursor increments independently, matching Helix. A hyphen not preceded by a digit is still interpreted as a negative sign. Vim mode behavior is unchanged (it continues to match Neovim). Also stay in HelixNormal after the operation so repeated increments keep working. Closes zed-industries#47356
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
first contribution
jgarte
marked this pull request as draft
May 29, 2026 21:28
Contributor
|
Vim mode behaviour is equally wrong and possibly a single fix is better? I don't know zed enough to make that decision but you might want to check my PR #58327 |
Contributor
Author
|
@kjyv Thanks for the message. I'll try to take a look soon. This week will be busy for me but give me about 2 weeks to get around to it. All best. |
Contributor
|
Keeping the PR queue a bit cleaner and will close this one for now, sorry: it's a draft PR with no activity for over a month and merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47356
Vim mode behavior is unchanged.
Release Notes:
2024-01-15(#47356).