Fix macOS system font fallback cascade append - #58020
Merged
Veykril merged 2 commits intoJun 5, 2026
Merged
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @douo on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes a bug where system font fallbacks were never appended because .map() produces a lazy iterator that was never consumed. Replaces it with a for loop that actually executes the side effect.
Changes:
- Replace lazy
.map()iterator with aforloop to ensureCFArrayAppendValueis invoked for each fallback descriptor.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zed-community-bot
Bot
added
the
first contribution
Contributor
Author
|
@cla-bot check |
cla-bot
Bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
smitbarmase
added
platform:macOS
Veykril
enabled auto-merge
June 5, 2026 15:11
Contributor
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
Fixes zed-industries#57916. `append_system_fallbacks` used `.map(...)` for the `CFArrayAppendValue` side effect, but the iterator was never consumed. This changes it to a `for` loop so the fallback descriptors are actually appended.
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Fixes zed-industries#57916. `append_system_fallbacks` used `.map(...)` for the `CFArrayAppendValue` side effect, but the iterator was never consumed. This changes it to a `for` loop so the fallback descriptors are actually appended.
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Fixes zed-industries#57916. `append_system_fallbacks` used `.map(...)` for the `CFArrayAppendValue` side effect, but the iterator was never consumed. This changes it to a `for` loop so the fallback descriptors are actually appended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57916.
append_system_fallbacksused.map(...)for theCFArrayAppendValueside effect, but the iterator was never consumed.This changes it to a
forloop so the fallback descriptors are actually appended.