Skip to content

edit_prediction: Skip unsigned Zeta requests - #57993

Closed
David3u wants to merge 1 commit into
zed-industries:mainfrom
David3u:Fix-edit_prediction-memory-leak
Closed

edit_prediction: Skip unsigned Zeta requests#57993
David3u wants to merge 1 commit into
zed-industries:mainfrom
David3u:Fix-edit_prediction-memory-leak

Conversation

@David3u

@David3u David3u commented May 28, 2026

Copy link
Copy Markdown
Contributor

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #57962

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 28, 2026
@MrSubidubi

MrSubidubi commented May 28, 2026

Copy link
Copy Markdown
Member

Thanks for this!

I'd like to close this in favor of #57615 which was already reviewed but would like to add your changes here to the test there - would that work for you?

@MrSubidubi

Copy link
Copy Markdown
Member

Went with that route and added you as a co-author there. Still, thank you for looking into this and getting the PR up!

@MrSubidubi MrSubidubi closed this May 29, 2026
@David3u

David3u commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

edit_prediction leaks memory on every failed attempt when not signed in (12 GB MALLOC_SMALL after 30 h, macOS arm64, Zed 1.4.2)

2 participants