Skip to content

agent_ui: Truncate long model names in config option selector - #57808

Merged
danilo-leal merged 2 commits into
zed-industries:mainfrom
Bitaru:fix/truncate-long-model-names
Jun 14, 2026
Merged

agent_ui: Truncate long model names in config option selector#57808
danilo-leal merged 2 commits into
zed-industries:mainfrom
Bitaru:fix/truncate-long-model-names

Conversation

@Bitaru

@Bitaru Bitaru commented May 27, 2026

Copy link
Copy Markdown
Contributor

Long model identifiers (e.g., AWS Bedrock ARNs) overflow the bottom toolbar, breaking the layout. Truncate display names to 32 characters with an ellipsis when they exceed 33 characters.

Before

after

After

before

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Agent: Improved truncation of long configuration button labels for external agents.

Long model identifiers (e.g., AWS Bedrock ARNs) overflow the bottom
toolbar, breaking the layout. Truncate display names to 32 characters
with an ellipsis when they exceed 33 characters.
@cla-bot

cla-bot Bot commented May 27, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @Bitaru on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label May 27, 2026
@Bitaru

Bitaru commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 27, 2026
@cla-bot

cla-bot Bot commented May 27, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@smitbarmase smitbarmase added the area:design papercut Small visual defects label May 27, 2026
@smitbarmase smitbarmase self-assigned this Jun 1, 2026

@danilo-leal danilo-leal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@danilo-leal
danilo-leal enabled auto-merge June 14, 2026 11:22
@danilo-leal
danilo-leal added this pull request to the merge queue Jun 14, 2026
Merged via the queue into zed-industries:main with commit c7987fa Jun 14, 2026
32 checks passed
This was referenced Jun 18, 2026
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…dustries#57808)

Long model identifiers (e.g., AWS Bedrock ARNs) overflow the bottom
toolbar, breaking the layout. Truncate display names to 32 characters
with an ellipsis when they exceed 33 characters.

### Before

<img width="1128" height="308" alt="after"
src="https://github.com/user-attachments/assets/000d5959-3bd5-4349-8f4e-09967ea7b2d8"
/>

### After

<img width="1010" height="212" alt="before"
src="https://github.com/user-attachments/assets/358fff8c-3bce-43ac-aed4-8ef630fc327b"
/>

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- Agent: Improved truncation of long configuration button labels for
external agents.

Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:design papercut Small visual defects cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants