Skip to content

component_preview: Clean up Component trait - #57731

Merged
MrSubidubi merged 3 commits into
mainfrom
some-cleanup
May 29, 2026
Merged

component_preview: Clean up Component trait#57731
MrSubidubi merged 3 commits into
mainfrom
some-cleanup

Conversation

@MrSubidubi

@MrSubidubi MrSubidubi commented May 26, 2026

Copy link
Copy Markdown
Member

This primarily

  • requires components to have a description as well as a preview (especially having no preview makes no sense)
  • implements some basic previews where missing
  • adds a scrollbar to the preview navigation

with a sadly large diff due to reformatting (less indentation 🎉 ), but very little changes at its core.

Release Notes:

  • N/A

@MrSubidubi
MrSubidubi requested a review from danilo-leal May 26, 2026 13:48
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 26, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 26, 2026
Comment thread crates/git_ui/src/git_panel.rs Outdated
Comment thread crates/ui/src/components/button/icon_button.rs Outdated
Comment thread crates/ui/src/components/keybinding.rs
@MrSubidubi
MrSubidubi added this pull request to the merge queue May 29, 2026
Merged via the queue into main with commit e4b8118 May 29, 2026
32 checks passed
@MrSubidubi
MrSubidubi deleted the some-cleanup branch May 29, 2026 07:09
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
This primarily
- requires components to have a description as well as a preview
(especially having no preview makes no sense)
- implements some basic previews where missing
- adds a scrollbar to the preview navigation 

with a sadly large diff due to reformatting (less indentation 🎉 ), but
very little changes at its core.

Release Notes:

- N/A
This was referenced Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
This primarily
- requires components to have a description as well as a preview
(especially having no preview makes no sense)
- implements some basic previews where missing
- adds a scrollbar to the preview navigation 

with a sadly large diff due to reformatting (less indentation 🎉 ), but
very little changes at its core.

Release Notes:

- N/A
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
This primarily
- requires components to have a description as well as a preview
(especially having no preview makes no sense)
- implements some basic previews where missing
- adds a scrollbar to the preview navigation 

with a sadly large diff due to reformatting (less indentation 🎉 ), but
very little changes at its core.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants