sidebar: Improve performance of rebuild_contents - #57717
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
Veykril
force-pushed
the
push-mrnsyowvqsxy
branch
3 times, most recently
from
May 26, 2026 10:31
a78fc75 to
79a1add
Compare
Veykril
commented
May 26, 2026
| .iter() | ||
| .filter(|(_, tracked)| tracked.has_edits(cx)) | ||
| .map(|(buffer, tracked)| (buffer.clone(), tracked.diff.clone())) | ||
| .collect() |
Member
Author
There was a problem hiding this comment.
Hot allocation, some callers, especially the sidebar iterates through at once (via diff_stats) wasting multiple allocations due to the use of BTreeMap, so let the caller decide instead. Most callers are also fine with a Vec, as the iteration order is already guaranteed
| .flat_map(|ws| all_thread_infos_for_workspace(ws, cx)); | ||
|
|
||
| let mut threads: Vec<ThreadEntry> = Vec::new(); | ||
| let mut threads: Vec<Arc<ThreadEntry>> = Vec::new(); |
Member
Author
There was a problem hiding this comment.
We later sort this and ThreadEntry is massive with ~700 bytes in size, causing us to spend a significant time in memcpy-ing around when sorting a larger number of threads
Veykril
force-pushed
the
push-mrnsyowvqsxy
branch
2 times, most recently
from
May 26, 2026 10:39
4f1c6de to
23296af
Compare
Veykril
force-pushed
the
push-mrnsyowvqsxy
branch
from
May 27, 2026 07:47
23296af to
de9d5e7
Compare
osiewicz
approved these changes
May 27, 2026
This was referenced Jun 3, 2026
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
Follow up on zed-industries#57717 Release Notes: - N/A or Added/Fixed/Improved ...
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Follow up on zed-industries#57717 Release Notes: - N/A or Added/Fixed/Improved ...
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Follow up on zed-industries#57717 Release Notes: - N/A or Added/Fixed/Improved ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes: