Fix error prompt darkened background exceeding window boundaries on Linux - #57608
Merged
smitbarmase merged 5 commits intoJun 8, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
first contribution
albertbogusz
changed the title
albertbogusz
changed the title
smitbarmase
enabled auto-merge
June 8, 2026 14:54
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…inux (zed-industries#57608) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior (visual difference only) - [x] Performance impact has been considered and is acceptable I was unable to find a specific issue or PR that mentions this. As Linux installations always use built-in prompts and ignore the `Use System Prompts` setting (as far as I'm aware) all users using Zed (with client-side decorations) are affected. The darkened prompt backdrop was drawn across the full window boundary, including the transparent decoration/shadow inset, causing it to overlap. This PR fixes the backdrop to respect the client-side decoration inset and only applies rounded corners on non-tiled edges. Tiled edges remain flush, matching the rest of the client-side window decoration behavior. I've verified it works on Wayland, X11 and causes no regressions on macOS or Windows (with `Use System Prompts` off). Notice the screenshots below on a white background showing the before and after, where the faint overlap is shown broken and fixed (sorry if you have to squint). Before:  After:  Release Notes: - Fixed prompt darkened backdrop/background rendering outside client-decorated window boundaries on Linux. --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…inux (zed-industries#57608) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior (visual difference only) - [x] Performance impact has been considered and is acceptable I was unable to find a specific issue or PR that mentions this. As Linux installations always use built-in prompts and ignore the `Use System Prompts` setting (as far as I'm aware) all users using Zed (with client-side decorations) are affected. The darkened prompt backdrop was drawn across the full window boundary, including the transparent decoration/shadow inset, causing it to overlap. This PR fixes the backdrop to respect the client-side decoration inset and only applies rounded corners on non-tiled edges. Tiled edges remain flush, matching the rest of the client-side window decoration behavior. I've verified it works on Wayland, X11 and causes no regressions on macOS or Windows (with `Use System Prompts` off). Notice the screenshots below on a white background showing the before and after, where the faint overlap is shown broken and fixed (sorry if you have to squint). Before:  After:  Release Notes: - Fixed prompt darkened backdrop/background rendering outside client-decorated window boundaries on Linux. --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
I was unable to find a specific issue or PR that mentions this.
As Linux installations always use built-in prompts and ignore the
Use System Promptssetting (as far as I'm aware) all users using Zed (with client-side decorations) are affected. The darkened prompt backdrop was drawn across the full window boundary, including the transparent decoration/shadow inset, causing it to overlap.This PR fixes the backdrop to respect the client-side decoration inset and only applies rounded corners on non-tiled edges. Tiled edges remain flush, matching the rest of the client-side window decoration behavior. I've verified it works on Wayland, X11 and causes no regressions on macOS or Windows (with
Use System Promptsoff).Notice the screenshots below on a white background showing the before and after, where the faint overlap is shown broken and fixed (sorry if you have to squint).
Before:
After:
Release Notes: