Skip to content

Escape seeded regex searches - #57584

Closed
ImFeH2 wants to merge 1 commit into
zed-industries:mainfrom
ImFeH2:issue-57253
Closed

Escape seeded regex searches#57584
ImFeH2 wants to merge 1 commit into
zed-industries:mainfrom
ImFeH2:issue-57253

Conversation

@ImFeH2

@ImFeH2 ImFeH2 commented May 24, 2026

Copy link
Copy Markdown
Contributor

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #57253

When regex search is enabled, opening search from a selection like z.d used to treat the . as part of the regex. This PR escapes selection-seeded searches first, so the selected text is searched literally. Typing a regex by hand still works the same as before.

Release Notes:

  • Fixed seeded searches in regex mode so selected text is matched literally.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 24, 2026
@smitbarmase smitbarmase added the area:search buffer search, project search, etc label May 25, 2026
@osiewicz

osiewicz commented Jul 2, 2026

Copy link
Copy Markdown
Member

Hey, thank you submitting a PR (and sorry for taking so long to get back to you); it looks like it's a duplicate of #57748 , so I'm gonna close this PR out. Thanks nonetheless!

@osiewicz osiewicz closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:search buffer search, project search, etc cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regex search doesn't escape seeded query

3 participants