editor: Extract header and mouse out of element.rs - #57472
Conversation
header and mouse.rs out of editor.rsheader and mouse out of element.rs
MrSubidubi
left a comment
There was a problem hiding this comment.
I personally think it does not make much sense if any to not have this in a subfolder for the element rendering - this is completely different from the other stuff and does not take Editor as self but EditorElement - that is an entirely different struct. I'd find it confusing to jump through these and remember that, as this is an entirely different story IMO
Would you prefer to have this structure instead: wdyt? |
|
I think that would be better, yes. Naming is up for debate, but personally feel this would make much more sense |
Alright, so I changed the file structure to that, please take a look |
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Today is my last day, but chimed in and left a few notes.
1febae8 to
d4c1786
Compare
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Thank you for the persistence.
Module system is straightened out now
…ies#57472) cc @SomeoneToIgnore ## Summary Follow-up to [this comment](zed-industries#55352 (reply in thread)). This extracts the buffer header and breadcrumb rendering helpers out of `element.rs` into a `header.rs` and mouse related things to `mouse.rs` Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
…ies#57472) cc @SomeoneToIgnore ## Summary Follow-up to [this comment](zed-industries#55352 (reply in thread)). This extracts the buffer header and breadcrumb rendering helpers out of `element.rs` into a `header.rs` and mouse related things to `mouse.rs` Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
…ies#57472) cc @SomeoneToIgnore ## Summary Follow-up to [this comment](zed-industries#55352 (reply in thread)). This extracts the buffer header and breadcrumb rendering helpers out of `element.rs` into a `header.rs` and mouse related things to `mouse.rs` Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
cc @SomeoneToIgnore
Summary
Follow-up to this comment. This extracts the buffer header and breadcrumb rendering helpers out of
element.rsinto aheader.rsand mouse related things tomouse.rsSelf-Review Checklist:
Release Notes: