image_viewer: Reveal images in file manager from keyboard shortcut - #56438
Merged
JosephTLyons merged 2 commits intoJun 8, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
ChristopherBiscardi
added
the
area:editor
terror
changed the title
JosephTLyons
self-requested a review
June 8, 2026 20:54
JosephTLyons
approved these changes
Jun 8, 2026
Collaborator
|
Hey @terror - sorry were late getting around to this PR, but all looks good on my end. I wish we could use the same keybinding here that we use in the project panel's Anyway, no issues with this PR, so I'm going to merge. Thank you! |
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…ed-industries#56438) Resolves zed-industries#55617 This diff makes the standard Reveal in Finder/File Manager shortcut work when an image tab is focused. Image tabs already expose the reveal action from the tab context menu, but the keyboard shortcut was only bound in the `Editor` context, so pressing `cmd-k r` on macOS or `ctrl-k r` on Linux/Windows did nothing while focus was in the image viewer. With this change, `ImageView` handles the existing `editor::RevealInFileManager` action, and the default keymaps bind the same reveal shortcut in the `ImageViewer` context. This keeps image tabs consistent with text editor tabs while reusing the same project path reveal path used elsewhere. Release Notes: - Fixed Reveal in Finder/File Manager shortcuts not working when an image tab is focused. Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ed-industries#56438) Resolves zed-industries#55617 This diff makes the standard Reveal in Finder/File Manager shortcut work when an image tab is focused. Image tabs already expose the reveal action from the tab context menu, but the keyboard shortcut was only bound in the `Editor` context, so pressing `cmd-k r` on macOS or `ctrl-k r` on Linux/Windows did nothing while focus was in the image viewer. With this change, `ImageView` handles the existing `editor::RevealInFileManager` action, and the default keymaps bind the same reveal shortcut in the `ImageViewer` context. This keeps image tabs consistent with text editor tabs while reusing the same project path reveal path used elsewhere. Release Notes: - Fixed Reveal in Finder/File Manager shortcuts not working when an image tab is focused. Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #55617
This diff makes the standard Reveal in Finder/File Manager shortcut work when an image tab is focused. Image tabs already expose the reveal action from the tab context menu, but the keyboard shortcut was only bound in the
Editorcontext, so pressingcmd-k ron macOS orctrl-k ron Linux/Windows did nothing while focus was in the image viewer.With this change,
ImageViewhandles the existingeditor::RevealInFileManageraction, and the default keymaps bind the same reveal shortcut in theImageViewercontext. This keeps image tabs consistent with text editor tabs while reusing the same project path reveal path used elsewhere.Release Notes: