edit_prediction_ui: Fix edit prediction provider checkmark - #56250
Merged
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @terror on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
Bot
added
the
first contribution
terror
force-pushed
the
edit-prediction-provider
branch
from
May 9, 2026 03:30
6effe9d to
448010a
Compare
cla-bot
Bot
added
the
cla-signed
MrSubidubi
requested changes
May 9, 2026
MrSubidubi
left a comment
MrSubidubi
left a comment
Member
There was a problem hiding this comment.
Thank you for looking into this!
The fix itself looks good, could you do me the favor of moving provider == EditPredictionProvider::Zed && is_zed_provider_disabled into a variable with fitting name and use that everywhere here?
MrSubidubi
requested changes
May 9, 2026
MrSubidubi
left a comment
MrSubidubi
left a comment
Member
There was a problem hiding this comment.
Nice, much better! Can we go for a better name here though? Like is_zed_provider_and_disabled or provider_is_zed_and_disabled? Not too big of a fan of either, if you have a better name (or disagree with me here), feel free to share!
Contributor
Author
|
MrSubidubi
approved these changes
May 9, 2026
MrSubidubi
left a comment
MrSubidubi
left a comment
Member
There was a problem hiding this comment.
Yeah good call indeed.
Treat yourself to some release notes as noted by the bot, otherwise looks good! Thanks for your contribution here, the quick follow-ups and congratulations to your first contribution! 🎉
Member
|
/cherry-pick preview |
This was referenced May 9, 2026
zed-zippy Bot
added a commit
that referenced
this pull request
May 9, 2026
…ew) (#56291) Cherry-pick of #56250 to preview ---- Resolves #56129 The edit prediction status bar menu only showed a checkmark for the active provider when that provider was Zed AI. Non-Zed providers such as Mercury could be selected and active, but the Providers section rendered them as unchecked because the toggle condition required `provider = EditPredictionProvider::Zed`. This updates the menu condition to show the checkmark for any active provider, while preserving the existing exception that hides the Zed AI checkmark when Zed AI is disabled by organization policy. <div align="center"> <img width="371" height="187" alt="Screenshot 2026-05-08 at 11 27 49 PM" src="https://github.com/user-attachments/assets/5278a102-bd7d-44a5-a655-74c6ed90b0f9" /> </div> Release Notes: - Fixed edit prediction provider menu checkmarks for active non-Zed providers. Co-authored-by: liam <liam@scalzulli.com>
zed-zippy Bot
added a commit
that referenced
this pull request
May 9, 2026
…e) (#56292) Cherry-pick of #56250 to stable ---- Resolves #56129 The edit prediction status bar menu only showed a checkmark for the active provider when that provider was Zed AI. Non-Zed providers such as Mercury could be selected and active, but the Providers section rendered them as unchecked because the toggle condition required `provider = EditPredictionProvider::Zed`. This updates the menu condition to show the checkmark for any active provider, while preserving the existing exception that hides the Zed AI checkmark when Zed AI is disabled by organization policy. <div align="center"> <img width="371" height="187" alt="Screenshot 2026-05-08 at 11 27 49 PM" src="https://github.com/user-attachments/assets/5278a102-bd7d-44a5-a655-74c6ed90b0f9" /> </div> Release Notes: - Fixed edit prediction provider menu checkmarks for active non-Zed providers. Co-authored-by: liam <liam@scalzulli.com>
terror
changed the title
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Resolves zed-industries#56129 The edit prediction status bar menu only showed a checkmark for the active provider when that provider was Zed AI. Non-Zed providers such as Mercury could be selected and active, but the Providers section rendered them as unchecked because the toggle condition required `provider = EditPredictionProvider::Zed`. This updates the menu condition to show the checkmark for any active provider, while preserving the existing exception that hides the Zed AI checkmark when Zed AI is disabled by organization policy. <div align="center"> <img width="371" height="187" alt="Screenshot 2026-05-08 at 11 27 49 PM" src="https://github.com/user-attachments/assets/5278a102-bd7d-44a5-a655-74c6ed90b0f9" /> </div> Release Notes: - Fixed edit prediction provider menu checkmarks for active non-Zed providers.
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Resolves zed-industries#56129 The edit prediction status bar menu only showed a checkmark for the active provider when that provider was Zed AI. Non-Zed providers such as Mercury could be selected and active, but the Providers section rendered them as unchecked because the toggle condition required `provider = EditPredictionProvider::Zed`. This updates the menu condition to show the checkmark for any active provider, while preserving the existing exception that hides the Zed AI checkmark when Zed AI is disabled by organization policy. <div align="center"> <img width="371" height="187" alt="Screenshot 2026-05-08 at 11 27 49 PM" src="https://github.com/user-attachments/assets/5278a102-bd7d-44a5-a655-74c6ed90b0f9" /> </div> Release Notes: - Fixed edit prediction provider menu checkmarks for active non-Zed providers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #56129
The edit prediction status bar menu only showed a checkmark for the active provider when that provider was Zed AI. Non-Zed providers such as Mercury could be selected and active, but the Providers section rendered them as unchecked because the toggle condition required
provider = EditPredictionProvider::Zed.This updates the menu condition to show the checkmark for any active provider, while preserving the existing exception that hides the Zed AI checkmark when Zed AI is disabled by organization policy.
Release Notes: