Skip to content

gpui: Use SharedString::new_static within From impls for ElementId where possible - #56139

Merged
MrSubidubi merged 2 commits into
mainfrom
gpui-static
May 8, 2026
Merged

gpui: Use SharedString::new_static within From impls for ElementId where possible#56139
MrSubidubi merged 2 commits into
mainfrom
gpui-static

Conversation

@MrSubidubi

Copy link
Copy Markdown
Member

Horror of a PR title but could not think of anything better here.

Release Notes:

  • N/A

@MrSubidubi
MrSubidubi requested a review from SomeoneToIgnore May 8, 2026 07:41
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 8, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 8, 2026
Comment thread crates/gpui/src/window.rs Outdated
Co-authored-by: Kirill Bulatov <kirill@zed.dev>
@MrSubidubi
MrSubidubi enabled auto-merge May 8, 2026 07:54
@MrSubidubi
MrSubidubi added this pull request to the merge queue May 8, 2026
Merged via the queue into main with commit e1a46f9 May 8, 2026
31 checks passed
@MrSubidubi
MrSubidubi deleted the gpui-static branch May 8, 2026 08:09
@kylekz kylekz mentioned this pull request May 8, 2026
3 tasks
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…Id` where possible (zed-industries#56139)

Horror of a PR title but could not think of anything better here.

Release Notes:

- N/A

---------

Co-authored-by: Kirill Bulatov <kirill@zed.dev>
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…Id` where possible (zed-industries#56139)

Horror of a PR title but could not think of anything better here.

Release Notes:

- N/A

---------

Co-authored-by: Kirill Bulatov <kirill@zed.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants