Fix multibuffer initialization based on RHS state - #56058
Merged
ChristopherBiscardi merged 1 commit intoMay 7, 2026
Merged
Conversation
This update modifies the initialization of the left-hand side multibuffer in the SplittableEditor. It now checks if the right-hand side multibuffer is a singleton and uses a more efficient `MultiBuffer::without_headers` method when applicable, improving performance and resource management. Release Notes: - Optimized multibuffer creation by conditionally using headers based on RHS state.
|
We require contributors to sign our Contributor License Agreement, and we don't have @chirivelli on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
Bot
added
the
first contribution
Collaborator
Author
|
@Veykril hi, I see you have the last commit related to diff in zed from the release notes from zed org, so just tagging you for review. @cole-miller, can you review this please |
Collaborator
Author
|
@cla-bot check |
cla-bot
Bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
chirivelli
marked this pull request as ready for review
May 7, 2026 14:19
maxdeviant
changed the title
ChristopherBiscardi
approved these changes
May 7, 2026
ChristopherBiscardi
left a comment
ChristopherBiscardi
left a comment
Contributor
There was a problem hiding this comment.
This fixes the extra spacing, thanks!
ChristopherBiscardi
enabled auto-merge
May 7, 2026 15:11
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
This update modifies the initialization of the left-hand side multibuffer in the SplittableEditor. It now checks if the right-hand side multibuffer is a singleton and uses a `MultiBuffer::without_headers` instead. Before Screenshot: <img width="1624" height="1030" alt="Screenshot 2026-05-07 at 7 30 16 PM" src="https://github.com/user-attachments/assets/3d963703-309c-42e4-b2be-fe64bd9c0a06" /> After Screenshot: <img width="1624" height="1030" alt="Screenshot 2026-05-07 at 7 32 48 PM" src="https://github.com/user-attachments/assets/51668319-6a34-47df-b8b1-8bf58b86407e" /> Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Optimized multibuffer creation by conditionally using headers based on RHS state.
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
This update modifies the initialization of the left-hand side multibuffer in the SplittableEditor. It now checks if the right-hand side multibuffer is a singleton and uses a `MultiBuffer::without_headers` instead. Before Screenshot: <img width="1624" height="1030" alt="Screenshot 2026-05-07 at 7 30 16 PM" src="https://github.com/user-attachments/assets/3d963703-309c-42e4-b2be-fe64bd9c0a06" /> After Screenshot: <img width="1624" height="1030" alt="Screenshot 2026-05-07 at 7 32 48 PM" src="https://github.com/user-attachments/assets/51668319-6a34-47df-b8b1-8bf58b86407e" /> Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Optimized multibuffer creation by conditionally using headers based on RHS state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update modifies the initialization of the left-hand side multibuffer in the SplittableEditor. It now checks if the right-hand side multibuffer is a singleton and uses a
MultiBuffer::without_headersinstead.Before Screenshot:
After Screenshot:
Self-Review Checklist:
Release Notes: