markdown_preview: Implement reload - #56016
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
benbrandt
marked this pull request as draft
May 7, 2026 08:17
If you implement can_save, you need to also support reload. Fix a bug introduced in #53236
benbrandt
force-pushed
the
fix-markdown-preview-reload
branch
from
May 7, 2026 08:18
463e0eb to
18cbadf
Compare
benbrandt
marked this pull request as ready for review
May 7, 2026 08:18
benbrandt
requested review from
a team,
as-cii,
nathansobo and
smitbarmase
and removed request for
a team,
as-cii and
nathansobo
May 7, 2026 08:19
smitbarmase
approved these changes
May 7, 2026
Member
Author
|
/cherry-pick preview |
5 tasks
Member
Author
|
/cherry-pick stable |
5 tasks
zed-zippy Bot
added a commit
that referenced
this pull request
May 7, 2026
…56026) Cherry-pick of #56016 to preview ---- If you implement can_save, you need to also support reload. Fix a bug introduced in #53236 Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed missing reload implementation for markdown preview. Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
zed-zippy Bot
added a commit
that referenced
this pull request
May 7, 2026
…56027) Cherry-pick of #56016 to stable ---- If you implement can_save, you need to also support reload. Fix a bug introduced in #53236 Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed missing reload implementation for markdown preview. Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
13 tasks
This was referenced May 11, 2026
Nkr1shna
pushed a commit
to neozed-industries/neo-zed
that referenced
this pull request
May 11, 2026
…k to stable) (zed-industries#56027) Cherry-pick of zed-industries#56016 to stable ---- If you implement can_save, you need to also support reload. Fix a bug introduced in zed-industries#53236 Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed missing reload implementation for markdown preview. Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
Nkr1shna
pushed a commit
to neozed-industries/neo-zed
that referenced
this pull request
May 13, 2026
…k to stable) (zed-industries#56027) Cherry-pick of zed-industries#56016 to stable ---- If you implement can_save, you need to also support reload. Fix a bug introduced in zed-industries#53236 Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed missing reload implementation for markdown preview. Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
If you implement can_save, you need to also support reload. Fix a bug introduced in zed-industries#53236 Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed missing reload implementation for markdown preview.
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
If you implement can_save, you need to also support reload. Fix a bug introduced in zed-industries#53236 Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed missing reload implementation for markdown preview.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you implement can_save, you need to also support reload. Fix a bug
introduced in #53236
Self-Review Checklist:
Release Notes: