editor: Extract fold, selection, coade_actions and completions out of editor.rs - #56010
Closed
GoldStrikeArch wants to merge 1 commit into
Conversation
GoldStrikeArch
marked this pull request as draft
May 7, 2026 07:21
GoldStrikeArch
marked this pull request as ready for review
May 7, 2026 08:24
Contributor
Author
Yeah, this is weird. It should be -4k lines. I guess there is some re-ordering I introduced. I will try to fix it |
fold, selection, coade_actions and completions out of editor.rs
GoldStrikeArch
force-pushed
the
feat/extract-fold-completions-codeactions-selection-out-of-editor
branch
2 times, most recently
from
May 7, 2026 09:21
d7b9960 to
0b7fcd7
Compare
GoldStrikeArch
force-pushed
the
feat/extract-fold-completions-codeactions-selection-out-of-editor
branch
from
May 7, 2026 09:40
0b7fcd7 to
c63c660
Compare
Contributor
Author
|
Looks like something is wrong with the diffing here from the Github/git because on my branch I can't solve it for some reason, so I decided to break them up into 2 sequential PRs, this is the first one -> #56030 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

cc @SomeoneToIgnore
Summary
Follow-up to #55352, where the conclusion was to split
editor.rsincrementally by topic instead of all at once.This extracts several editor topics into focused sibling modules:
crates/editor/src/fold.rscrates/editor/src/code_actions.rscrates/editor/src/completions.rscrates/editor/src/selection.rsWhile doing the extraction, this also tightens the module boundaries instead of preserving every old access path by inertia:
context_menustorage and replaces external usage with focused APIs for code actions and completions state.editor.rs, since those APIs are not selection-specific.linked_editing_ranges.rs, closer to its only real caller.Self-Review Checklist:
Release Notes: