Skip to content

Remove unused --nc flag and nc crate - #55962

Merged
bennetbo merged 1 commit into
mainfrom
remove-nc-crate
May 29, 2026
Merged

Remove unused --nc flag and nc crate#55962
bennetbo merged 1 commit into
mainfrom
remove-nc-crate

Conversation

@agu-z

@agu-z agu-z commented May 6, 2026

Copy link
Copy Markdown
Contributor

The nc crate and zed --nc <socket> flag were added in #34577 to let the Claude Code integration spawn the running zed binary as a netcat-style bridge between stdio and a Unix socket for its MCP server.

That integration was removed in #37120 in favor of the external @agentclientprotocol/claude-agent-acp npm package, which dropped the only caller of --nc. The flag, its dispatch in main.rs, and the nc crate itself were left behind and have been unused since.

Nothing in the Zed codebase spawns zed --nc anymore, so remove the flag and delete the crate. The unrelated --askpass netcat bridge (in the askpass crate) is unaffected.

Release Notes:

  • N/A

The `nc` crate and `zed --nc <socket>` flag were added in #34577 to let
the Claude Code integration spawn the running zed binary as a netcat-
style bridge between stdio and a Unix socket for its MCP server.

That integration was removed in #37120 in favor of the external
`@zed-industries/claude-code-acp` npm package, which dropped the only
caller of `--nc`. The flag, its dispatch in `main.rs`, and the `nc`
crate itself were left behind and have been unused since.

Nothing in the Zed codebase spawns `zed --nc` anymore, so remove the
flag and delete the crate. The unrelated `--askpass` netcat bridge (in
the `askpass` crate) is unaffected.
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 6, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 6, 2026
@agu-z
agu-z requested a review from bennetbo May 28, 2026 21:09
@bennetbo
bennetbo added this pull request to the merge queue May 29, 2026
Merged via the queue into main with commit ef5da3c May 29, 2026
43 checks passed
@bennetbo
bennetbo deleted the remove-nc-crate branch May 29, 2026 08:18
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
The `nc` crate and `zed --nc <socket>` flag were added in zed-industries#34577 to let
the Claude Code integration spawn the running zed binary as a
netcat-style bridge between stdio and a Unix socket for its MCP server.

That integration was removed in zed-industries#37120 in favor of the external
`@agentclientprotocol/claude-agent-acp` npm package, which dropped the
only caller of `--nc`. The flag, its dispatch in `main.rs`, and the `nc`
crate itself were left behind and have been unused since.

Nothing in the Zed codebase spawns `zed --nc` anymore, so remove the
flag and delete the crate. The unrelated `--askpass` netcat bridge (in
the `askpass` crate) is unaffected.

Release Notes:

- N/A
This was referenced Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
The `nc` crate and `zed --nc <socket>` flag were added in zed-industries#34577 to let
the Claude Code integration spawn the running zed binary as a
netcat-style bridge between stdio and a Unix socket for its MCP server.

That integration was removed in zed-industries#37120 in favor of the external
`@agentclientprotocol/claude-agent-acp` npm package, which dropped the
only caller of `--nc`. The flag, its dispatch in `main.rs`, and the `nc`
crate itself were left behind and have been unused since.

Nothing in the Zed codebase spawns `zed --nc` anymore, so remove the
flag and delete the crate. The unrelated `--askpass` netcat bridge (in
the `askpass` crate) is unaffected.

Release Notes:

- N/A
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
The `nc` crate and `zed --nc <socket>` flag were added in zed-industries#34577 to let
the Claude Code integration spawn the running zed binary as a
netcat-style bridge between stdio and a Unix socket for its MCP server.

That integration was removed in zed-industries#37120 in favor of the external
`@agentclientprotocol/claude-agent-acp` npm package, which dropped the
only caller of `--nc`. The flag, its dispatch in `main.rs`, and the `nc`
crate itself were left behind and have been unused since.

Nothing in the Zed codebase spawns `zed --nc` anymore, so remove the
flag and delete the crate. The unrelated `--askpass` netcat bridge (in
the `askpass` crate) is unaffected.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants