Skip to content

Promote queued message to main editor on paste - #55780

Merged
agu-z merged 1 commit into
mainfrom
promote-queued-message-on-paste
May 5, 2026
Merged

Promote queued message to main editor on paste#55780
agu-z merged 1 commit into
mainfrom
promote-queued-message-on-paste

Conversation

@agu-z

@agu-z agu-z commented May 5, 2026

Copy link
Copy Markdown
Contributor

Pasting text or an image into a queued-message editor used to be a silent no-op for text and a panic for images.

This change makes pasting into a queued message behave like typing into one: the queued message is promoted into the main editor at the cursor position, and the paste is then applied there.

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #55521

Release Notes:

  • Fixed a crash when pasting an image into a queued message

Pasting text or an image into a queued-message editor used to be a silent no-op for text and a panic for images.

This change makes pasting into a queued message behave like typing into one: the queued message is promoted into the main editor at the cursor position, and the paste is then applied there.

Closes #55521
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 5, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 5, 2026
@agu-z
agu-z requested a review from bennetbo May 5, 2026 14:58
@agu-z
agu-z added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit f5bd159 May 5, 2026
41 checks passed
@agu-z
agu-z deleted the promote-queued-message-on-paste branch May 5, 2026 15:10
@agu-z

agu-z commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick preview

zed-zippy Bot added a commit that referenced this pull request May 5, 2026
…to preview) (#55785)

Cherry-pick of #55780 to preview

----
Pasting text or an image into a queued-message editor used to be a
silent no-op for text and a panic for images.

This change makes pasting into a queued message behave like typing into
one: the queued message is promoted into the main editor at the cursor
position, and the paste is then applied there.

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX

checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes #55521

Release Notes:

- Fixed a crash when pasting an image into a queued message

Co-authored-by: Agus Zubiaga <agus@zed.dev>
ebaah46 pushed a commit to ebaah46/zed that referenced this pull request May 6, 2026
Pasting text or an image into a queued-message editor used to be a
silent no-op for text and a panic for images.

This change makes pasting into a queued message behave like typing into
one: the queued message is promoted into the main editor at the cursor
position, and the paste is then applied there.

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes zed-industries#55521

Release Notes:

- Fixed a crash when pasting an image into a queued message
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
Pasting text or an image into a queued-message editor used to be a
silent no-op for text and a panic for images.

This change makes pasting into a queued message behave like typing into
one: the queued message is promoted into the main editor at the cursor
position, and the paste is then applied there.

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes zed-industries#55521

Release Notes:

- Fixed a crash when pasting an image into a queued message
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
Pasting text or an image into a queued-message editor used to be a
silent no-op for text and a panic for images.

This change makes pasting into a queued message behave like typing into
one: the queued message is promoted into the main editor at the cursor
position, and the paste is then applied there.

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes zed-industries#55521

Release Notes:

- Fixed a crash when pasting an image into a queued message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when pasting image into queued agent message

2 participants