Skip to content

agent: Allow model to provide stringified timezone in now tool - #55776

Merged
bennetbo merged 1 commit into
mainfrom
stringified-timezone-tool
May 5, 2026
Merged

agent: Allow model to provide stringified timezone in now tool#55776
bennetbo merged 1 commit into
mainfrom
stringified-timezone-tool

Conversation

@bennetbo

@bennetbo bennetbo commented May 5, 2026

Copy link
Copy Markdown
Member

See #55186 (comment)

I think the recent changes to the tool schema in #55763 will make this more unlikely, but does not hurt to allow the model to provide "utc".

Release Notes:

  • N/A

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 5, 2026
@bennetbo
bennetbo requested a review from benbrandt May 5, 2026 14:32
@zed-industries-bot

This comment was marked as off-topic.

@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 5, 2026
@bennetbo
bennetbo added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit 02af528 May 5, 2026
41 checks passed
@bennetbo
bennetbo deleted the stringified-timezone-tool branch May 5, 2026 14:43
@zed-zippy zed-zippy Bot added the PR state:needs review Used to label PRs that are in need of a post-merge approval label May 5, 2026
@maxbrunsfeld

Copy link
Copy Markdown
Collaborator

@zed-industries/approved

@zed-zippy zed-zippy Bot removed the PR state:needs review Used to label PRs that are in need of a post-merge approval label May 5, 2026
ebaah46 pushed a commit to ebaah46/zed that referenced this pull request May 6, 2026
…ed-industries#55776)

See
zed-industries#55186 (comment)

I think the recent changes to the tool schema in zed-industries#55763 will make this
more unlikely, but does not hurt to allow the model to provide `"utc"`.

Release Notes:

- N/A
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…ed-industries#55776)

See
zed-industries#55186 (comment)

I think the recent changes to the tool schema in zed-industries#55763 will make this
more unlikely, but does not hurt to allow the model to provide `"utc"`.

Release Notes:

- N/A
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…ed-industries#55776)

See
zed-industries#55186 (comment)

I think the recent changes to the tool schema in zed-industries#55763 will make this
more unlikely, but does not hurt to allow the model to provide `"utc"`.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants