Skip to content

Update panel dock default values in settings docs - #55719

Merged
ChristopherBiscardi merged 1 commit into
zed-industries:mainfrom
javier-solis:update-panel-dock-defaults-docs
May 5, 2026
Merged

Update panel dock default values in settings docs#55719
ChristopherBiscardi merged 1 commit into
zed-industries:mainfrom
javier-solis:update-panel-dock-defaults-docs

Conversation

@javier-solis

Copy link
Copy Markdown
Contributor

The Parallel Agents release introduced a new default layout: the agent panel now docks on the left, while the project, git, outline, and collaboration panels now dock on the right. The rustdoc comments in crates/settings_content were not updated to reflect this change.

This PR corrects the Default: values in the following structs:

  • ProjectPanelSettingsContent.dock: leftright
  • GitPanelSettingsContent.dock: leftright
  • PanelSettingsContent.dock (collaboration panel): leftright
  • OutlinePanelSettingsContent.dock: leftright
  • AgentSettingsContent.dock: rightleft

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • N/A

@cla-bot

cla-bot Bot commented May 5, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @javier-solis on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label May 5, 2026
@ChristopherBiscardi ChristopherBiscardi self-assigned this May 5, 2026
@ChristopherBiscardi

Copy link
Copy Markdown
Contributor

The changes here look fine. please sign the CLA when you get a chance

The parallel agents release (https://zed.dev/blog/parallel-agents)
changed the default layout: agent/threads panel now defaults to the
left dock, while project, git, outline, and collaboration panels now
default to the right. The rustdocs in settings_content were not
updated to reflect this.
@javier-solis
javier-solis force-pushed the update-panel-dock-defaults-docs branch from 8474ddb to 971a466 Compare May 5, 2026 03:28
@cla-bot

cla-bot Bot commented May 5, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @javier-solis on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@javier-solis

Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot

cla-bot Bot commented May 5, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @javier-solis on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot

cla-bot Bot commented May 5, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@javier-solis

Copy link
Copy Markdown
Contributor Author

Done, thanks @ChristopherBiscardi!

FYI - force pushed to re-sign the commit with the correct GPG key.

@javier-solis

Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 5, 2026
@cla-bot

cla-bot Bot commented May 5, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@ChristopherBiscardi
ChristopherBiscardi added this pull request to the merge queue May 5, 2026
Merged via the queue into zed-industries:main with commit 62507a1 May 5, 2026
39 checks passed
@javier-solis
javier-solis deleted the update-panel-dock-defaults-docs branch May 5, 2026 04:37
ebaah46 pushed a commit to ebaah46/zed that referenced this pull request May 6, 2026
The [Parallel Agents release](https://zed.dev/blog/parallel-agents)
introduced a new default layout: the agent panel now docks on the left,
while the project, git, outline, and collaboration panels now dock on
the right. The rustdoc comments in `crates/settings_content` were not
updated to reflect this change.

This PR corrects the `Default:` values in the following structs:

- `ProjectPanelSettingsContent.dock`: `left` → `right`
- `GitPanelSettingsContent.dock`: `left` → `right`
- `PanelSettingsContent.dock` (collaboration panel): `left` → `right`
- `OutlinePanelSettingsContent.dock`: `left` → `right`
- `AgentSettingsContent.dock`: `right` → `left`

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- N/A
@yeskunall

Copy link
Copy Markdown
Member

@lingyaochu raised a valid concern in #56277 (comment) that this PR doesn’t fully address. The default isn’t unconditionally right. It depends on the active Panel layout:

  • Classic (WindowLayout::Editor) → left
  • Agentic (WindowLayout::Agent) → right

See PanelLayout::EDITOR vs PanelLayout::AGENT in crates/agent_settings/src/agent_settings.rs. So the doc as it stands is now wrong for Classic users in the same way it was previously wrong for Agentic users -- now it’s just flipped.

jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
The [Parallel Agents release](https://zed.dev/blog/parallel-agents)
introduced a new default layout: the agent panel now docks on the left,
while the project, git, outline, and collaboration panels now dock on
the right. The rustdoc comments in `crates/settings_content` were not
updated to reflect this change.

This PR corrects the `Default:` values in the following structs:

- `ProjectPanelSettingsContent.dock`: `left` → `right`
- `GitPanelSettingsContent.dock`: `left` → `right`
- `PanelSettingsContent.dock` (collaboration panel): `left` → `right`
- `OutlinePanelSettingsContent.dock`: `left` → `right`
- `AgentSettingsContent.dock`: `right` → `left`

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- N/A
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
The [Parallel Agents release](https://zed.dev/blog/parallel-agents)
introduced a new default layout: the agent panel now docks on the left,
while the project, git, outline, and collaboration panels now dock on
the right. The rustdoc comments in `crates/settings_content` were not
updated to reflect this change.

This PR corrects the `Default:` values in the following structs:

- `ProjectPanelSettingsContent.dock`: `left` → `right`
- `GitPanelSettingsContent.dock`: `left` → `right`
- `PanelSettingsContent.dock` (collaboration panel): `left` → `right`
- `OutlinePanelSettingsContent.dock`: `left` → `right`
- `AgentSettingsContent.dock`: `right` → `left`

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants