Update panel dock default values in settings docs - #55719
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @javier-solis on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The changes here look fine. please sign the CLA when you get a chance |
The parallel agents release (https://zed.dev/blog/parallel-agents) changed the default layout: agent/threads panel now defaults to the left dock, while project, git, outline, and collaboration panels now default to the right. The rustdocs in settings_content were not updated to reflect this.
8474ddb to
971a466
Compare
|
We require contributors to sign our Contributor License Agreement, and we don't have @javier-solis on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @javier-solis on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Done, thanks @ChristopherBiscardi! FYI - force pushed to re-sign the commit with the correct GPG key. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
The [Parallel Agents release](https://zed.dev/blog/parallel-agents) introduced a new default layout: the agent panel now docks on the left, while the project, git, outline, and collaboration panels now dock on the right. The rustdoc comments in `crates/settings_content` were not updated to reflect this change. This PR corrects the `Default:` values in the following structs: - `ProjectPanelSettingsContent.dock`: `left` → `right` - `GitPanelSettingsContent.dock`: `left` → `right` - `PanelSettingsContent.dock` (collaboration panel): `left` → `right` - `OutlinePanelSettingsContent.dock`: `left` → `right` - `AgentSettingsContent.dock`: `right` → `left` Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
|
@lingyaochu raised a valid concern in #56277 (comment) that this PR doesn’t fully address. The default isn’t unconditionally
See |
The [Parallel Agents release](https://zed.dev/blog/parallel-agents) introduced a new default layout: the agent panel now docks on the left, while the project, git, outline, and collaboration panels now dock on the right. The rustdoc comments in `crates/settings_content` were not updated to reflect this change. This PR corrects the `Default:` values in the following structs: - `ProjectPanelSettingsContent.dock`: `left` → `right` - `GitPanelSettingsContent.dock`: `left` → `right` - `PanelSettingsContent.dock` (collaboration panel): `left` → `right` - `OutlinePanelSettingsContent.dock`: `left` → `right` - `AgentSettingsContent.dock`: `right` → `left` Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
The [Parallel Agents release](https://zed.dev/blog/parallel-agents) introduced a new default layout: the agent panel now docks on the left, while the project, git, outline, and collaboration panels now dock on the right. The rustdoc comments in `crates/settings_content` were not updated to reflect this change. This PR corrects the `Default:` values in the following structs: - `ProjectPanelSettingsContent.dock`: `left` → `right` - `GitPanelSettingsContent.dock`: `left` → `right` - `PanelSettingsContent.dock` (collaboration panel): `left` → `right` - `OutlinePanelSettingsContent.dock`: `left` → `right` - `AgentSettingsContent.dock`: `right` → `left` Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
The Parallel Agents release introduced a new default layout: the agent panel now docks on the left, while the project, git, outline, and collaboration panels now dock on the right. The rustdoc comments in
crates/settings_contentwere not updated to reflect this change.This PR corrects the
Default:values in the following structs:ProjectPanelSettingsContent.dock:left→rightGitPanelSettingsContent.dock:left→rightPanelSettingsContent.dock(collaboration panel):left→rightOutlinePanelSettingsContent.dock:left→rightAgentSettingsContent.dock:right→leftSelf-Review Checklist:
Release Notes: