Skip to content

git_panel: Fix commit message text behind Open Commit Modal button - #55565

Merged
ChristopherBiscardi merged 2 commits into
zed-industries:mainfrom
RemcoSmitsDev:fix-git-commit-editor-text-behind-button
May 5, 2026
Merged

git_panel: Fix commit message text behind Open Commit Modal button#55565
ChristopherBiscardi merged 2 commits into
zed-industries:mainfrom
RemcoSmitsDev:fix-git-commit-editor-text-behind-button

Conversation

@RemcoSmitsDev

@RemcoSmitsDev RemcoSmitsDev commented May 3, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes an issue where the your commit message inside the git panel commit editor could be behind the Open Commit Modal button.

Before
Screenshot 2026-05-03 at 18 11 33

After
Screenshot 2026-05-05 at 18 18 58

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fix git commit message editor text could be behind the Open Commit Modal button

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 3, 2026
@github-actions github-actions Bot added the community champion Issues filed by our amazing community champions! 🫶 label May 3, 2026
@SomeoneToIgnore SomeoneToIgnore added the area:integrations/git Git integration feedback label May 3, 2026

@ChristopherBiscardi ChristopherBiscardi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think switching the icons to a vertical list here makes more sense, since it won't additionally restrict the width of the available space for content and lends itself to more space for any additional future icons.

Comment thread crates/git_ui/src/git_panel.rs
@ChristopherBiscardi ChristopherBiscardi self-assigned this May 4, 2026
@RemcoSmitsDev

Copy link
Copy Markdown
Collaborator Author

Hey @ChristopherBiscardi, thanks for your review! I have applied your feedback.

@ChristopherBiscardi ChristopherBiscardi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the PR!

@ChristopherBiscardi
ChristopherBiscardi added this pull request to the merge queue May 5, 2026
Merged via the queue into zed-industries:main with commit 3fab3af May 5, 2026
31 checks passed
@RemcoSmitsDev
RemcoSmitsDev deleted the fix-git-commit-editor-text-behind-button branch May 5, 2026 17:51
ebaah46 pushed a commit to ebaah46/zed that referenced this pull request May 6, 2026
…ed-industries#55565)

This PR fixes an issue where the your commit message inside the git
panel commit editor could be behind the `Open Commit Modal` button.

**Before**
<img width="391" height="180" alt="Screenshot 2026-05-03 at 18 11 33"
src="https://github.com/user-attachments/assets/f9c68665-ca82-4fb0-80e1-d501891f5ef5"
/>

**After**
<img width="359" height="179" alt="Screenshot 2026-05-05 at 18 18 58"
src="https://github.com/user-attachments/assets/1ff610c7-5758-4446-9666-67c194b1d3f9"
/>

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- Fix git commit message editor text could be behind the `Open Commit
Modal` button
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…ed-industries#55565)

This PR fixes an issue where the your commit message inside the git
panel commit editor could be behind the `Open Commit Modal` button.

**Before**
<img width="391" height="180" alt="Screenshot 2026-05-03 at 18 11 33"
src="https://github.com/user-attachments/assets/f9c68665-ca82-4fb0-80e1-d501891f5ef5"
/>

**After**
<img width="359" height="179" alt="Screenshot 2026-05-05 at 18 18 58"
src="https://github.com/user-attachments/assets/1ff610c7-5758-4446-9666-67c194b1d3f9"
/>

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- Fix git commit message editor text could be behind the `Open Commit
Modal` button
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…ed-industries#55565)

This PR fixes an issue where the your commit message inside the git
panel commit editor could be behind the `Open Commit Modal` button.

**Before**
<img width="391" height="180" alt="Screenshot 2026-05-03 at 18 11 33"
src="https://github.com/user-attachments/assets/f9c68665-ca82-4fb0-80e1-d501891f5ef5"
/>

**After**
<img width="359" height="179" alt="Screenshot 2026-05-05 at 18 18 58"
src="https://github.com/user-attachments/assets/1ff610c7-5758-4446-9666-67c194b1d3f9"
/>

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- Fix git commit message editor text could be behind the `Open Commit
Modal` button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:integrations/git Git integration feedback cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants