settings_ui: Toggle root navbar entries on double-click - #55526
Merged
ChristopherBiscardi merged 1 commit intoMay 5, 2026
Merged
Conversation
Allow root entries in the Settings navbar to expand or collapse when double-clicked, while preserving the existing single-click navigation behavior.
Contributor
Author
zed-settings-nav-double-click-toggle2.mp4 |
ChristopherBiscardi
approved these changes
May 5, 2026
ChristopherBiscardi
left a comment
Contributor
There was a problem hiding this comment.
We currently do nothing on double-click, so this makes the larger click target available.
- Clicking a category switches to that page
- Clicking the dropdown icon toggles the collapsed status and switches to that page
- With this PR, a single click on the category switches to the page and the double click toggles the collapsed status (in addition to keeping the prior two behaviors)
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
…es#55526) Settings navbar root entries can now be expanded or collapsed by double-clicking the row itself. Single-click navigation is preserved, so clicking a root entry still opens the selected Settings page. The double-click handler only toggles on `click_count() == 2`, so triple-clicking the row does not toggle it again. The double-click path reuses the same toggle-and-focus behavior as the disclosure chevron. Testing: - `cargo fmt --check --package settings_ui` - `cargo check -p settings_ui` - `cargo test -p settings_ui` - Manually verified that: - single-clicking a Settings navbar root entry still opens the selected Settings page - double-clicking a Settings navbar root entry expands or collapses it - triple-clicking the row does not toggle the entry again - clicking the disclosure chevron still expands or collapses the entry Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Improved Settings navigation by allowing root navbar entries to expand or collapse on double-click.
This was referenced May 13, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…es#55526) Settings navbar root entries can now be expanded or collapsed by double-clicking the row itself. Single-click navigation is preserved, so clicking a root entry still opens the selected Settings page. The double-click handler only toggles on `click_count() == 2`, so triple-clicking the row does not toggle it again. The double-click path reuses the same toggle-and-focus behavior as the disclosure chevron. Testing: - `cargo fmt --check --package settings_ui` - `cargo check -p settings_ui` - `cargo test -p settings_ui` - Manually verified that: - single-clicking a Settings navbar root entry still opens the selected Settings page - double-clicking a Settings navbar root entry expands or collapses it - triple-clicking the row does not toggle the entry again - clicking the disclosure chevron still expands or collapses the entry Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Improved Settings navigation by allowing root navbar entries to expand or collapse on double-click.
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…es#55526) Settings navbar root entries can now be expanded or collapsed by double-clicking the row itself. Single-click navigation is preserved, so clicking a root entry still opens the selected Settings page. The double-click handler only toggles on `click_count() == 2`, so triple-clicking the row does not toggle it again. The double-click path reuses the same toggle-and-focus behavior as the disclosure chevron. Testing: - `cargo fmt --check --package settings_ui` - `cargo check -p settings_ui` - `cargo test -p settings_ui` - Manually verified that: - single-clicking a Settings navbar root entry still opens the selected Settings page - double-clicking a Settings navbar root entry expands or collapses it - triple-clicking the row does not toggle the entry again - clicking the disclosure chevron still expands or collapses the entry Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Improved Settings navigation by allowing root navbar entries to expand or collapse on double-click.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings navbar root entries can now be expanded or collapsed by double-clicking the row itself.
Single-click navigation is preserved, so clicking a root entry still opens the selected Settings page. The double-click handler only toggles on
click_count() == 2, so triple-clicking the row does not toggle it again.The double-click path reuses the same toggle-and-focus behavior as the disclosure chevron.
Testing:
cargo fmt --check --package settings_uicargo check -p settings_uicargo test -p settings_uiSelf-Review Checklist:
Release Notes: