Repository navigation
edit tool: Support stringified mode parameter - #55498
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
agu-z
marked this pull request as ready for review
May 2, 2026 15:46
agu-z
force-pushed
the
edit-tool-handle-double-encoded-enum
branch
from
May 2, 2026 15:47
a3b42be to
3deb4e3
Compare
cameron1024
approved these changes
May 2, 2026
bennetbo
approved these changes
May 2, 2026
Member
|
/cherry-pick preview |
Member
|
/cherry-pick stable |
This was referenced May 2, 2026
zed-zippy Bot
added a commit
that referenced
this pull request
May 2, 2026
… to preview) (#55499) Cherry-pick of #55498 to preview ---- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed an issue where agent failed to apply edits in some cases Co-authored-by: Agus Zubiaga <agus@zed.dev>
zed-zippy Bot
added a commit
that referenced
this pull request
May 2, 2026
… to stable) (#55500) Cherry-pick of #55498 to stable ---- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed an issue where agent failed to apply edits in some cases Co-authored-by: Agus Zubiaga <agus@zed.dev>
6 tasks
aviddiviner
added a commit
to aviddiviner/zed
that referenced
this pull request
May 4, 2026
Upstream changes: - edit tool: Support stringified `mode` parameter (zed-industries#55498) Fixes models that double-encode JSON tool parameters - Remove StreamingEditFileToolFeatureFlag (now always enabled) - cloud_llm_client: Add cursor_offset to PredictEditsV3Response - Version bump to 1.0.1 Conflict resolutions: - crates/agent/src/thread.rs: Removed feature_flags import entirely (we already removed UpdatePlanToolFeatureFlag, upstream removed StreamingEditFileToolFeatureFlag — neither is used anymore) - Cargo.lock: Kept our version (no zed crate) - crates/edit_prediction/*, crates/zed/Cargo.toml: Kept deleted (these crates don't exist in Aleph)
Nkr1shna
added a commit
to neozed-industries/neo-zed
that referenced
this pull request
May 4, 2026
* edit tool: Support stringified `mode` parameter (zed-industries#55498) (cherry-pick to stable) (zed-industries#55500) Cherry-pick of zed-industries#55498 to stable ---- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed an issue where agent failed to apply edits in some cases Co-authored-by: Agus Zubiaga <agus@zed.dev> * Bump to 1.0.1 for @bennetbo --------- Co-authored-by: zed-zippy[bot] <234243425+zed-zippy[bot]@users.noreply.github.com> Co-authored-by: Agus Zubiaga <agus@zed.dev>
Nkr1shna
added a commit
to neozed-industries/neo-zed
that referenced
this pull request
May 4, 2026
* edit tool: Support stringified `mode` parameter (zed-industries#55498) (cherry-pick to stable) (zed-industries#55500) Cherry-pick of zed-industries#55498 to stable ---- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed an issue where agent failed to apply edits in some cases Co-authored-by: Agus Zubiaga <agus@zed.dev> * Bump to 1.0.1 for @bennetbo --------- Co-authored-by: zed-zippy[bot] <234243425+zed-zippy[bot]@users.noreply.github.com> Co-authored-by: Agus Zubiaga <agus@zed.dev>
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
This was referenced May 8, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
Release Notes: