Fix zeta2 prompt format selection - #55338
Conversation
|
This isn't going to be very helpful but - I built this fork and tested it against an unquantized zeta 2 running on VLLM and was still getting nonsense completions just as I was before this fix. |
|
Thanks @kaytwo! Very helpful I haven't merged this because I was waiting to be at home where I could test it properly. Will investigate! |
|
I've got the model set to zeta2 (trying zeta made for different gibberish edits). I'm not sure at this point whether it's an issue with Zed itself vs. the version of the model posted to huggingface. When I switch to "Zed AI" in the same buffer, I get edit suggestions that I would expect. Here are some captures of the completion requests that are being made by zed, which look like I'd expect from the description of zeta 2. By far the most often completion suggestion I get is the "delete the whole file" version that just sends back empty completionnonsense completion |
|
Hmm, finally had a chance to test, and I'm not seeing any issues. @kaytwo do you happen to have |
a09fa16 to
fc38279
Compare
|
Works for me. Thank you! Video_2026-05-08_01-13-45.mp4PS Do I smell Zeta 2.1 incoming with diagnostics support? 👀 |
|
/cherry-pick preview |
|
🍒💥 Cherry-pick did not succeed |
|
🍒💥 Cherry-pick did not succeed |
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #52585 Release Notes: - Fixed local zeta2 edit predictions using the wrong prompt format.
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #52585 Release Notes: - Fixed local zeta2 edit predictions using the wrong prompt format.
|
/cherry-pick preview |
…56191) Cherry-pick of #55338 to preview ---- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #52585 Release Notes: - Fixed local zeta2 edit predictions using the wrong prompt format. Co-authored-by: Ben Kunkle <ben@zed.dev>
…56192) Cherry-pick of #55338 to stable ---- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #52585 Release Notes: - Fixed local zeta2 edit predictions using the wrong prompt format. Co-authored-by: Ben Kunkle <ben@zed.dev>
Local zeta2.1 on vllm is giving me roughly the same suggestions I am getting through Zed AI - Zeta2 was still not really working, but not sure how useful it is to chase that particular issue down. Thanks for your help @probably-neb! |
|
Glad to hear it @kaytwo! Out of curiousity what GPU are you running it on, what's your vllm command, and what is your latency like? Trying to get a better feel for how it's running out in the wild |
|
@probably-neb: |
… to stable) (zed-industries#56192) Cherry-pick of zed-industries#55338 to stable ---- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#52585 Release Notes: - Fixed local zeta2 edit predictions using the wrong prompt format. Co-authored-by: Ben Kunkle <ben@zed.dev>
… to stable) (zed-industries#56192) Cherry-pick of zed-industries#55338 to stable ---- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#52585 Release Notes: - Fixed local zeta2 edit predictions using the wrong prompt format. Co-authored-by: Ben Kunkle <ben@zed.dev>
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#52585 Release Notes: - Fixed local zeta2 edit predictions using the wrong prompt format.
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#52585 Release Notes: - Fixed local zeta2 edit predictions using the wrong prompt format.
Self-Review Checklist:
Closes #52585
Release Notes: