Skip to content

agent_ui: Preserve selection mentions when starting a new thread - #55203

Merged
NeelChotai merged 4 commits into
mainfrom
neel/agent-panel-preserve-selection-mentions
May 7, 2026
Merged

agent_ui: Preserve selection mentions when starting a new thread#55203
NeelChotai merged 4 commits into
mainfrom
neel/agent-panel-preserve-selection-mentions

Conversation

@NeelChotai

Copy link
Copy Markdown
Member

When the "+" button created a fresh draft, active_initial_content
fell back to the raw editor text when the async draft_prompt
observer had not yet resolved. That raw text contains fold placeholder
strings (e.g. "selection") rather than the mention links, so creases
and their registered URIs were dropped from the carried-over draft.

Related to #53981.

Release Notes:

  • Fixed a bug where selection mentions would resolve to the literal selection rather than the URI in draft threads.

When the "+" button created a fresh draft, `active_initial_content`
fell back to the raw editor text when the async `draft_prompt`
observer had not yet resolved. That raw text contains fold placeholder
strings (e.g. "selection") rather than the mention links, so creases
and their registered URIs were dropped from the carried-over draft.

Related to #53981.
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 29, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Apr 29, 2026
@zed-industries-bot

zed-industries-bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor
Messages
📖

This PR includes links to the following GitHub Issues: #53981
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against 4772ade

@NeelChotai
NeelChotai added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 9a125a5 May 7, 2026
31 checks passed
@NeelChotai
NeelChotai deleted the neel/agent-panel-preserve-selection-mentions branch May 7, 2026 12:43
@zed-zippy zed-zippy Bot added the PR state:needs review Used to label PRs that are in need of a post-merge approval label May 7, 2026
@gaauwe

gaauwe commented May 11, 2026

Copy link
Copy Markdown
Contributor

@zed-zippy approved

@zed-zippy zed-zippy Bot removed the PR state:needs review Used to label PRs that are in need of a post-merge approval label May 11, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…-industries#55203)

When the "+" button created a fresh draft, `active_initial_content`
fell back to the raw editor text when the async `draft_prompt`
observer had not yet resolved. That raw text contains fold placeholder
strings (e.g. "selection") rather than the mention links, so creases
and their registered URIs were dropped from the carried-over draft.

Related to zed-industries#53981.

Release Notes:

- Fixed a bug where selection mentions would resolve to the literal
`selection` rather than the URI in draft threads.
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…-industries#55203)

When the "+" button created a fresh draft, `active_initial_content`
fell back to the raw editor text when the async `draft_prompt`
observer had not yet resolved. That raw text contains fold placeholder
strings (e.g. "selection") rather than the mention links, so creases
and their registered URIs were dropped from the carried-over draft.

Related to zed-industries#53981.

Release Notes:

- Fixed a bug where selection mentions would resolve to the literal
`selection` rather than the URI in draft threads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants