agent_ui: Insert dropped file links at the cursor - #55127
Merged
Veykril merged 2 commits intoJun 15, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
SomeoneToIgnore
added
the
area:ai
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
## Context Dragging a file from the Project Panel into the agent composer was appending the generated file mention to the end of the prompt instead of inserting it at the active caret position. This change routes dragged file insertion through the same caret-based mention insertion path already used for pasted external paths, so dropped file and directory mentions are inserted inline where the user is typing. Closes zed-industries#55002 Video of the manual test below : [Screencast from 2026-04-29 01-13-59.webm](https://github.com/user-attachments/assets/9d2196fb-accd-4f4a-a9c0-0ce45b212121) ## How to Review - [crates/agent_ui/src/message_editor.rs](/home/saber/coding/zed/crates/agent_ui/src/message_editor.rs) removes the separate end-of-buffer insertion mode from `insert_mention_for_project_path`, updates `insert_dragged_files` to use the shared caret-based insertion flow, and adds regression tests covering single-file and multi-file drag insertion order at the cursor. The existing paste-at-cursor behavior remains covered by the pre-existing test in the same module. ## Self-Review Checklist - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the UI/UX checklist - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed dragged file mentions in the agent composer being appended to the end of the prompt instead of inserted at the cursor Co-authored-by: Richard Feldman <richard@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Dragging a file from the Project Panel into the agent composer was appending the generated file mention to the end of the prompt instead of inserting it at the active caret position. This change routes dragged file insertion through the same caret-based mention insertion path already used for pasted external paths, so dropped file and directory mentions are inserted inline where the user is typing.
Closes #55002
Video of the manual test below :
Screencast.from.2026-04-29.01-13-59.webm
How to Review
insert_mention_for_project_path, updatesinsert_dragged_filesto use the shared caret-based insertion flow, and adds regression tests covering single-file and multi-file drag insertion order at the cursor. The existing paste-at-cursor behavior remains covered by the pre-existing test in the same module.Self-Review Checklist
Release Notes: