Skip to content

Fix the test for non-dev test runs (#55089) #55091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SomeoneToIgnore merged 1 commit into from
Apr 28, 2026
Merged

Fix the test for non-dev test runs (#55089) #55091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions crates/settings/src/settings_store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1786,11 +1786,10 @@ mod tests {

#[gpui::test]
fn test_default_settings_release_channel_overrides(cx: &mut App) {
assert_eq!(
*release_channel::RELEASE_CHANNEL,
release_channel::ReleaseChannel::Dev,
"tests expect the dev release channel",
);
// The test deals with overrides and should ignore the other set-ups (Preview and Stable runs)
if *release_channel::RELEASE_CHANNEL != release_channel::ReleaseChannel::Dev {
return;
}

let mut defaults: serde_json::Value =
crate::parse_json_with_comments(&default_settings()).unwrap();
Expand Down
Loading