docs: Update actions format - #54869
Conversation
MrSubidubi
left a comment
There was a problem hiding this comment.
Thanks for this, good find! Could we instead please use the docs preprocessor syntax for this to ensure these are always rendered properly and exist?
|
I noticed that some other actions also don't follow the format. Should I fix them as well while I'm at it? It should be a very straightforward review. |
|
Sure, feel free to! |
I take that back—it's not as straightforward as I expected. I found quite a few cases, some of them outdated. I've addressed everything I found via regex, but I'm not entirely sure if anything is left. Additionally, I noticed that some platform-specific actions, such as |
There was a problem hiding this comment.
Still a very nice change and the other stuff is definitely something worth looking into after.
However, could you please look into removing the backticks everywhere, please? The syntax itself will ensure that the keybinds will be rendered in monospace, so we can safely remove the backticks. Thanks!
Also, definitely would like to note that
but I’ll leave it out of this PR to keep things focused.
is a very good idea and approach and I appreciate it very much, thanks!
Done |
MrSubidubi
left a comment
There was a problem hiding this comment.
Very very very nice, thank you so much!
|
/cherry-pick stable |
Head branch was pushed to by a user without write access
|
Sorry, there are some style issues, should be resolved now. |
|
All good, no need to apologize, that happens too often to me too. |
Cherry-pick of #54869 to preview ---- Self-Review Checklist: - [ ] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Change the actions in docs to adopt the right format. Release Notes: - N/A Co-authored-by: Xin Zhao <zx0@mail.ustc.edu.cn>
Cherry-pick of #54869 to stable ---- Self-Review Checklist: - [ ] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Change the actions in docs to adopt the right format. Release Notes: - N/A Co-authored-by: Xin Zhao <zx0@mail.ustc.edu.cn>
…able) (zed-industries#56006) Cherry-pick of zed-industries#54869 to stable ---- Self-Review Checklist: - [ ] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Change the actions in docs to adopt the right format. Release Notes: - N/A Co-authored-by: Xin Zhao <zx0@mail.ustc.edu.cn>
…able) (zed-industries#56006) Cherry-pick of zed-industries#54869 to stable ---- Self-Review Checklist: - [ ] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Change the actions in docs to adopt the right format. Release Notes: - N/A Co-authored-by: Xin Zhao <zx0@mail.ustc.edu.cn>
Self-Review Checklist: - [ ] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Change the actions in docs to adopt the right format. Release Notes: - N/A
Self-Review Checklist: - [ ] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Change the actions in docs to adopt the right format. Release Notes: - N/A
Self-Review Checklist: - [ ] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Change the actions in docs to adopt the right format. Release Notes: - N/A
Self-Review Checklist:
Change the actions in docs to adopt the right format.
Release Notes: