debugger: Fix running ignored Rust tests in nested modules - #54787
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
tomhoule
changed the title
tomhoule
changed the title
tomhoule
marked this pull request as ready for review
April 27, 2026 19:40
tomhoule
changed the title
Debugging a Rust test whose code lives in a nested module (e.g. `variant_get::test::get_complex_variant`) sometimes exited immediately with "0 tests matched", When the test name itself came from tree-sitter runnable capture, which sees only the bare function identifier. So `--exact get_complex_variant` filtered out the actual test. The fix is to only append `--exact` when the name contains `::`. rust-analyzer's `experimental/runnables` produces qualified paths and keeps the #43110 disambiguation benefit, and the runnables from tree-sitter no longer break for nested modules. Closes #51810. Release Notes: - Fixed debugging Rust tests in nested modules sometimes immediately exiting with "0 tests matched".
tomhoule
force-pushed
the
tomhoule-zlxzkpvpsksq
branch
from
May 20, 2026 10:22
7d79c45 to
dc2cfe7
Compare
cole-miller
approved these changes
Jun 10, 2026
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…tries#54787) Debugging an ignored Rust test whose code lives in a nested module (e.g. `variant_get::test::get_complex_variant`) sometimes exited immediately with "0 tests matched", When the test name itself came from tree-sitter runnable capture, which sees only the bare function identifier. So `--exact get_complex_variant` filtered out the actual test. The fix is to only append `--exact` when the name contains `::`. rust-analyzer's `experimental/runnables` produces qualified paths and keeps the disambiguation introduced in zed-industries#43110, and the runnables from tree-sitter no longer break for nested modules. Closes zed-industries#51810. Release Notes: - Fixed debugging Rust tests in nested modules sometimes immediately exiting with "0 tests matched".
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…tries#54787) Debugging an ignored Rust test whose code lives in a nested module (e.g. `variant_get::test::get_complex_variant`) sometimes exited immediately with "0 tests matched", When the test name itself came from tree-sitter runnable capture, which sees only the bare function identifier. So `--exact get_complex_variant` filtered out the actual test. The fix is to only append `--exact` when the name contains `::`. rust-analyzer's `experimental/runnables` produces qualified paths and keeps the disambiguation introduced in zed-industries#43110, and the runnables from tree-sitter no longer break for nested modules. Closes zed-industries#51810. Release Notes: - Fixed debugging Rust tests in nested modules sometimes immediately exiting with "0 tests matched".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugging an ignored Rust test whose code lives in a nested module (e.g.
variant_get::test::get_complex_variant) sometimes exited immediately with "0 tests matched", When the test name itself came from tree-sitter runnable capture, which sees only the bare function identifier. So--exact get_complex_variantfiltered out the actual test.The fix is to only append
--exactwhen the name contains::. rust-analyzer'sexperimental/runnablesproduces qualified paths and keeps the disambiguation introduced in #43110, and the runnables from tree-sitter no longer break for nested modules.Closes #51810.
Release Notes: