deepseek: Add deepseek-v4-pro & deepseek-v4-flash by cppcoffee · Pull Request #54731 · zed-industries/zed

cppcoffee · 2026-04-24T03:14:05Z

reference: https://api-docs.deepseek.com/

Closes #54492.

Release Notes:

Added deepseek-v4-pro and deepseek-v4-flash models

lingyaochu · 2026-04-24T03:23:28Z

Maybe we also need to change the context length and the max output tokens.

cppcoffee · 2026-04-24T03:28:37Z

Maybe we also need to change the context length and the max output tokens.

done

lingyaochu · 2026-04-24T03:30:26Z

#54492 This issue seems related, but I'm not sure if this PR could close that.

lingyaochu · 2026-04-24T03:34:33Z

DeepSeek introduces reasoning effort when in thinking mode, does Zed support this setting? If so, we should also do a change there.

shenjackyuanjie · 2026-04-24T03:54:30Z

I think we should remove the deprcated DeepSeek Chat/Reasoner model name, as they are now route to V4 flash thinking/none thinking, and will be removed later

https://api-docs.deepseek.com/

shenjackyuanjie

DeepSeek Chat, DeepSeek Reasoner should be removed

shenjackyuanjie · 2026-04-24T03:58:11Z

-            // Their API treats this max against the context window, which means we hit the limit a lot
-            // Using the default value of None in the API instead
-            Self::Chat | Self::Reasoner => None,
+            Self::Chat | Self::Reasoner | Self::V4Flash | Self::V4Pro => Some(384_000),


remove chat & reeasoner

The model names deepseek-chat and deepseek-reasoner will be deprecated on 2026/07/24. For compatibility, they correspond to the non-thinking mode and thinking mode of deepseek-v4-flash, respectively.

Would it be better to wait until July to delete it?

The model names deepseek-chat and deepseek-reasoner will be deprecated on 2026/07/24. For compatibility, they correspond to the non-thinking mode and thinking mode of deepseek-v4-flash, respectively.

Would it be better to wait until July to delete it?

I dont think so, as these two name will generate confuse when using

The old models deleted.

From my view point, we should remove the old chat and reasoner model in Zed, because they are only nick names for v4 flash and pro. We couldn't give two models which look different but in fact are the same. Deepseek is the provider, they need to keep the old name for some compatibility, give some time for users (like Zed) to migrate, as the migration is easy for Zed (from I see), we should do it now.

cppcoffee · 2026-04-24T04:33:57Z

DeepSeek introduces reasoning effort when in thinking mode, does Zed support this setting? If so, we should also do a change there.

Effort Control supported.

lingyaochu · 2026-04-24T05:01:33Z

我想起来个事，既然要移除 chat/reasoner，是不是应该写一个config迁移来着，毕竟这会影响到现有config

I remember something. Since we are removing chat/reasoner, shouldn't we write a config migration? After all, this will affect the existing config

I don't get it, which config are you talking about? Could you please give an example?

shenjackyuanjie · 2026-04-24T05:23:47Z

我想起来个事，既然要移除 chat/reasoner，是不是应该写一个config迁移来着，毕竟这会影响到现有config
I remember something. Since we are removing chat/reasoner, shouldn't we write a config migration? After all, this will affect the existing config

I don't get it, which config are you talking about? Could you please give an example?

like in settings file, do we need to translate deepseek-reasoner to deepseek-v4-flash-thinking

cppcoffee · 2026-04-24T05:35:46Z

我想起来个事，既然要移除 chat/reasoner，是不是应该写一个config迁移来着，毕竟这会影响到现有config
I remember something. Since we are removing chat/reasoner, shouldn't we write a config migration? After all, this will affect the existing config

I don't get it, which config are you talking about? Could you please give an example?

like in settings file, do we need to translate deepseek-reasoner to deepseek-v4-flash-thinking

It's fine, users fill in this model name themselves, which is different from the built-in ones.

cppcoffee · 2026-04-24T12:27:25Z

Test as follows:

2026-04-24.20.23.57.mov

cppcoffee · 2026-04-25T04:31:27Z

@cppcoffee 还有个事, deepseek现在对有toolcall的是保留全部thinking，无toolcall的 (text thread, 这玩意还有吗) 只保留单次thinking, 这个你做了吗, 我好像没看到相关代码

For turns with tool calls: retain and return all reasoning_content/thinking of that turn.
For turns without tool calls: historical reasoning_content will no longer be included in subsequent context; I have already cleared it before sending it to DeepSeek.

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>

yeskunall · 2026-04-27T05:29:53Z

Please do not @- mention team members on your PRs. You guys have polluted this thread with your unnecessary comments. This will be looked at by someone when they get the chance.

cppcoffee · 2026-04-27T06:59:23Z

Please do not @- mention team members on your PRs. You guys have polluted this thread with your unnecessary comments. This will be looked at by someone when they get the chance.

Sorry, I mainly really want this feature, after all the Deepseek API is on sale...

Sherlock-Holo · 2026-04-27T07:12:12Z

will this PR support the new tool call format DSML? I search the word in PR but found nothing...

cppcoffee · 2026-04-27T07:29:48Z

will this PR support the new tool call format DSML? I search the word in PR but found nothing...

I did not see any DSML format in the API documentation https://api-docs.deepseek.com/

Sherlock-Holo · 2026-04-27T09:13:23Z

will this PR support the new tool call format DSML? I search the word in PR but found nothing...

I did not see any DSML format in the API documentation https://api-docs.deepseek.com/

https://huggingface.co/deepseek-ai/DeepSeek-V4-Flash/blob/main/encoding/README.md

https://huggingface.co/deepseek-ai/DeepSeek-V4-Pro/blob/main/encoding/README.md

both of them mention the DSML

Co-authored-by: MrSubidubi <dev@bahn.sh>

benbrandt · 2026-04-27T14:00:59Z

/cherry-pick preview

…ck to preview) (#55010) Cherry-pick of #54731 to preview ---- reference: https://api-docs.deepseek.com/ Release Notes: - Added deepseek-v4-pro and deepseek-v4-flash models --------- Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com> Co-authored-by: MrSubidubi <dev@bahn.sh> Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com> Co-authored-by: Xiaobo Liu <cppcoffee@gmail.com> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com> Co-authored-by: MrSubidubi <dev@bahn.sh>

reference: https://api-docs.deepseek.com/ Release Notes: - Added deepseek-v4-pro and deepseek-v4-flash models --------- Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com> Co-authored-by: MrSubidubi <dev@bahn.sh>

…) (cherry-pick to preview) (zed-industries#55010) Cherry-pick of zed-industries#54731 to preview ---- reference: https://api-docs.deepseek.com/ Release Notes: - Added deepseek-v4-pro and deepseek-v4-flash models --------- Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com> Co-authored-by: MrSubidubi <dev@bahn.sh> Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com> Co-authored-by: Xiaobo Liu <cppcoffee@gmail.com> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com> Co-authored-by: MrSubidubi <dev@bahn.sh>

reference: https://api-docs.deepseek.com/ Release Notes: - Added deepseek-v4-pro and deepseek-v4-flash models --------- Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com> Co-authored-by: MrSubidubi <dev@bahn.sh>

cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 24, 2026

cppcoffee force-pushed the deepseek-v4-pro-flash branch from 32040a9 to ee8529c Compare April 24, 2026 03:14

cppcoffee force-pushed the deepseek-v4-pro-flash branch from ee8529c to e9523b7 Compare April 24, 2026 03:25

shenjackyuanjie suggested changes Apr 24, 2026

View reviewed changes

cppcoffee force-pushed the deepseek-v4-pro-flash branch from 47f9395 to 3a24178 Compare April 24, 2026 04:31

cppcoffee force-pushed the deepseek-v4-pro-flash branch 2 times, most recently from 341a3cc to 9876a1f Compare April 24, 2026 04:53

This comment was marked as outdated.

Sign in to view

This comment was marked as duplicate.

Sign in to view

SomeoneToIgnore added the area:ai Related to Agent Panel, Edit Prediction, Copilot, or other AI features label Apr 24, 2026

cppcoffee changed the title ~~deepseek: add deepseek-v4-pro & deepseek-v4-flash~~ deepseek: Add deepseek-v4-pro & deepseek-v4-flash Apr 24, 2026

cppcoffee force-pushed the deepseek-v4-pro-flash branch 2 times, most recently from abacc75 to 8d5cc11 Compare April 24, 2026 12:26

This comment was marked as resolved.

Sign in to view

cppcoffee force-pushed the deepseek-v4-pro-flash branch from d3b649e to 219f4e6 Compare April 25, 2026 03:45

This comment was marked as spam.

Sign in to view

deepseek: Add deepseek-v4-pro & deepseek-v4-flash

e35d3ae

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>

cppcoffee force-pushed the deepseek-v4-pro-flash branch from 7b65baa to e35d3ae Compare April 25, 2026 07:04

cppcoffee requested a review from shenjackyuanjie April 25, 2026 09:37

This comment was marked as off-topic.

Sign in to view

This comment was marked as low quality.

Sign in to view

yeskunall mentioned this pull request Apr 27, 2026

deepseek v4 flash new thinking format is not supported #54953

Closed

Revert unnecessary changes

2c3cb2d

Co-authored-by: MrSubidubi <dev@bahn.sh>

benbrandt approved these changes Apr 27, 2026

View reviewed changes

benbrandt enabled auto-merge April 27, 2026 13:40

benbrandt disabled auto-merge April 27, 2026 13:40

benbrandt enabled auto-merge April 27, 2026 13:40

benbrandt disabled auto-merge April 27, 2026 13:40

benbrandt enabled auto-merge April 27, 2026 13:41

benbrandt added this pull request to the merge queue Apr 27, 2026

Merged via the queue into zed-industries:main with commit 4c27cee Apr 27, 2026
32 checks passed

zed-zippy Bot mentioned this pull request Apr 27, 2026

deepseek: Add deepseek-v4-pro & deepseek-v4-flash (#54731) (cherry-pick to preview) #55010

Merged

cppcoffee deleted the deepseek-v4-pro-flash branch April 28, 2026 07:00

github-actions Bot mentioned this pull request May 8, 2026

Review upstream Zed v1.1.6 neozed-industries/neo-zed#18

Closed

Uh oh!

Uh oh!

Conversation

cppcoffee commented Apr 24, 2026 • edited by yeskunall Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lingyaochu commented Apr 24, 2026

Uh oh!

cppcoffee commented Apr 24, 2026

Uh oh!

lingyaochu commented Apr 24, 2026

Uh oh!

lingyaochu commented Apr 24, 2026

Uh oh!

shenjackyuanjie commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shenjackyuanjie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shenjackyuanjie Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

cppcoffee Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

shenjackyuanjie Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

cppcoffee Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

lingyaochu Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

cppcoffee Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

cppcoffee commented Apr 24, 2026

Uh oh!

This comment was marked as outdated.

lingyaochu commented Apr 24, 2026

Uh oh!

shenjackyuanjie commented Apr 24, 2026

Uh oh!

cppcoffee commented Apr 24, 2026

Uh oh!

This comment was marked as duplicate.

cppcoffee commented Apr 24, 2026

Uh oh!

This comment was marked as resolved.

cppcoffee commented Apr 25, 2026

Uh oh!

This comment was marked as spam.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as low quality.

yeskunall commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cppcoffee commented Apr 27, 2026

Uh oh!

Sherlock-Holo commented Apr 27, 2026

Uh oh!

cppcoffee commented Apr 27, 2026

Uh oh!

Sherlock-Holo commented Apr 27, 2026

Uh oh!

Uh oh!

benbrandt commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

cppcoffee commented Apr 24, 2026 •

edited by yeskunall

Loading

shenjackyuanjie commented Apr 24, 2026 •

edited

Loading

yeskunall commented Apr 27, 2026 •

edited

Loading