feature_flags: Fix issue where staff is not automatically signed into collab - #54332
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-zippy
Bot
added
the
PR state:needs review
Member
|
@zed-zippy approved |
zed-zippy
Bot
removed
the
PR state:needs review
Member
Author
|
/cherry-pick preview |
5 tasks
zed-zippy Bot
added a commit
that referenced
this pull request
Apr 22, 2026
… collab (#54332) (cherry-pick to preview) (#54483) Cherry-pick of #54332 to preview ---- Follow up to #54206 `on_flags_ready` relied on the fact that the `FeatureFlagStore` was only set once the flags had been received from the server. However, after #54206 the global gets instantiated earlier, without the flags being resolved. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A Co-authored-by: Bennet Bo Fenner <bennet@zed.dev>
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
… collab (zed-industries#54332) Follow up to zed-industries#54206 `on_flags_ready` relied on the fact that the `FeatureFlagStore` was only set once the flags had been received from the server. However, after zed-industries#54206 the global gets instantiated earlier, without the flags being resolved. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
Zenor27
pushed a commit
to Zenor27/zed
that referenced
this pull request
Jul 4, 2026
… collab (zed-industries#54332) Follow up to zed-industries#54206 `on_flags_ready` relied on the fact that the `FeatureFlagStore` was only set once the flags had been received from the server. However, after zed-industries#54206 the global gets instantiated earlier, without the flags being resolved. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
… collab (zed-industries#54332) Follow up to zed-industries#54206 `on_flags_ready` relied on the fact that the `FeatureFlagStore` was only set once the flags had been received from the server. However, after zed-industries#54206 the global gets instantiated earlier, without the flags being resolved. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
… collab (zed-industries#54332) Follow up to zed-industries#54206 `on_flags_ready` relied on the fact that the `FeatureFlagStore` was only set once the flags had been received from the server. However, after zed-industries#54206 the global gets instantiated earlier, without the flags being resolved. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #54206
on_flags_readyrelied on the fact that theFeatureFlagStorewas only set once the flags had been received from the server.However, after #54206 the global gets instantiated earlier, without the flags being resolved.
Self-Review Checklist:
Release Notes: