git: Only show header staging checkboxes when hovering the header itself - #54204
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
Anthony-Eid
approved these changes
Apr 22, 2026
Member
Author
|
/cherry-pick preview |
Contributor
|
🍒💥 Cherry-pick did not succeed |
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
…elf (zed-industries#54204) Previously, we would show these checkboxes whenever hovering anywhere in the `entries` group, which covers all headers and status entries. This seems excessive, and also has a problem that the header checkboxes disappear when the mouse moves over a non-header (status entry) checkbox, presumably because those have `stop_propagation`. Now, we only show the checkbox for a header when that specific header is hovered. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
Zenor27
pushed a commit
to Zenor27/zed
that referenced
this pull request
Jul 4, 2026
…elf (zed-industries#54204) Previously, we would show these checkboxes whenever hovering anywhere in the `entries` group, which covers all headers and status entries. This seems excessive, and also has a problem that the header checkboxes disappear when the mouse moves over a non-header (status entry) checkbox, presumably because those have `stop_propagation`. Now, we only show the checkbox for a header when that specific header is hovered. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…elf (zed-industries#54204) Previously, we would show these checkboxes whenever hovering anywhere in the `entries` group, which covers all headers and status entries. This seems excessive, and also has a problem that the header checkboxes disappear when the mouse moves over a non-header (status entry) checkbox, presumably because those have `stop_propagation`. Now, we only show the checkbox for a header when that specific header is hovered. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…elf (zed-industries#54204) Previously, we would show these checkboxes whenever hovering anywhere in the `entries` group, which covers all headers and status entries. This seems excessive, and also has a problem that the header checkboxes disappear when the mouse moves over a non-header (status entry) checkbox, presumably because those have `stop_propagation`. Now, we only show the checkbox for a header when that specific header is hovered. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we would show these checkboxes whenever hovering anywhere in the
entriesgroup, which covers all headers and status entries. This seems excessive, and also has a problem that the header checkboxes disappear when the mouse moves over a non-header (status entry) checkbox, presumably because those havestop_propagation. Now, we only show the checkbox for a header when that specific header is hovered.Self-Review Checklist:
Release Notes: