Skip to content

Fix info colors used for hint diagnostics - #54046

Merged
Veykril merged 2 commits into
zed-industries:mainfrom
vonEdfa:fix-info-color-for-hint-diagnostics
Apr 20, 2026
Merged

Fix info colors used for hint diagnostics#54046
Veykril merged 2 commits into
zed-industries:mainfrom
vonEdfa:fix-info-color-for-hint-diagnostics

Conversation

@vonEdfa

@vonEdfa vonEdfa commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Super small update changing two instances where DiagnosticSeverity::HINT was set to use the color for "info".

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #45637

Release Notes:

  • Fixed various instances of hint level diagnostics using the color designated for info

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Apr 16, 2026
@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Apr 16, 2026
@zed-codeowner-coordinator
zed-codeowner-coordinator Bot requested review from a team, cameron1024, dinocosta and eholk and removed request for a team April 16, 2026 08:03
@vonEdfa

vonEdfa commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

I left the test checkbox unchecked as I could not find any existing tests covering the lines changed and since this is my first contribution and I was unsure about the preferred practice for these instances. I also honestly wanted to keep the changes simple and small.

If you wish me to add tests for these lines let me know and I'll look into it. Otherwise we can check that box too. :)

@Veykril Veykril left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril
Veykril enabled auto-merge (squash) April 20, 2026 08:47
@Veykril
Veykril merged commit 9e2c493 into zed-industries:main Apr 20, 2026
42 checks passed
@vonEdfa
vonEdfa deleted the fix-info-color-for-hint-diagnostics branch May 6, 2026 06:13
kathbigra pushed a commit to kathbigra/zed that referenced this pull request May 10, 2026
Super small update changing two instances where
`DiagnosticSeverity::HINT` was set to use the color for "info".

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes zed-industries#45637

Release Notes:

- Fixed various instances of hint level diagnostics using the color
designated for info
Zenor27 pushed a commit to Zenor27/zed that referenced this pull request Jul 4, 2026
Super small update changing two instances where
`DiagnosticSeverity::HINT` was set to use the color for "info".

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes zed-industries#45637

Release Notes:

- Fixed various instances of hint level diagnostics using the color
designated for info
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
Super small update changing two instances where
`DiagnosticSeverity::HINT` was set to use the color for "info".

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes zed-industries#45637

Release Notes:

- Fixed various instances of hint level diagnostics using the color
designated for info
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
Super small update changing two instances where
`DiagnosticSeverity::HINT` was set to use the color for "info".

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes zed-industries#45637

Release Notes:

- Fixed various instances of hint level diagnostics using the color
designated for info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hint diagnostics underlined as info

4 participants