acp_thread: Support absolute file mentions with row fragments - #53229
Merged
benbrandt merged 4 commits intoMay 3, 2026
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @Revantark on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
Bot
added
the
first contribution
zed-codeowner-coordinator
Bot
requested review from
a team,
bennetbo and
maxbrunsfeld
and removed request for
a team
April 6, 2026 11:23
Contributor
Author
|
@cla-bot check |
cla-bot
Bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
ChristopherBiscardi
added
the
area:ai
|
Will this also correctly recognize paths surrounded by backticks? |
Contributor
Author
I missed this case. It doesn't handle it right now. I will push a fix. Thanks |
Contributor
Author
|
@alpharder pushed a fix. |
eholk
approved these changes
Apr 27, 2026
Contributor
Author
|
@eholk I have updated the tests to include windows parsing. |
This was referenced May 3, 2026
|
Thank you! |
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
…dustries#53229) Sometimes the contents in the agent's thread are direct file links. Codex ACP almost every time uses absolute file paths instead of file://path/to/file. This is resulting in an error described in the zed-industries#49978 . Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#49978 Release Notes: - Fixed absolute path mentions in `acp_thread` so direct file references (including `:line` and `#Lline` formats) now open correctly instead of resolving to invalid/empty files. --------- Co-authored-by: Eric Holk <eric@zed.dev>
This was referenced May 13, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…dustries#53229) Sometimes the contents in the agent's thread are direct file links. Codex ACP almost every time uses absolute file paths instead of file://path/to/file. This is resulting in an error described in the zed-industries#49978 . Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#49978 Release Notes: - Fixed absolute path mentions in `acp_thread` so direct file references (including `:line` and `#Lline` formats) now open correctly instead of resolving to invalid/empty files. --------- Co-authored-by: Eric Holk <eric@zed.dev>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…dustries#53229) Sometimes the contents in the agent's thread are direct file links. Codex ACP almost every time uses absolute file paths instead of file://path/to/file. This is resulting in an error described in the zed-industries#49978 . Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#49978 Release Notes: - Fixed absolute path mentions in `acp_thread` so direct file references (including `:line` and `#Lline` formats) now open correctly instead of resolving to invalid/empty files. --------- Co-authored-by: Eric Holk <eric@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the contents in the agent's thread are direct file links. Codex ACP almost every time uses absolute file paths instead of file://path/to/file. This is resulting in an error described in the #49978 .
Self-Review Checklist:
Closes #49978
Release Notes:
acp_threadso direct file references (including:lineand#Llineformats) now open correctly instead of resolving to invalid/empty files.