Skip to content

Grace period for inaccessible workspaces #52638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ojpro wants to merge 7 commits into from
Closed

Grace period for inaccessible workspaces #52638

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eac53ea
workspace: add 7-day grace period for inaccessible local workspaces
ojpro Mar 5, 2026
07f93c6
Merge branch 'main' into grace-period-for-inaccessible-workspaces
ojpro Mar 5, 2026
3d5d2aa
workspace: ref grace period to pass a timestamp instead of a boolean
ojpro Mar 6, 2026
fec882b
ref[workspace]: hide missing workspaces within the 7-day grace period
ojpro Mar 28, 2026
dc26b8d
Merge branch 'main' into grace-period-for-inaccessible-workspaces
ojpro Mar 28, 2026
79e3401
fix[workspace]: hide non-existing projects
ojpro Apr 3, 2026
4bf0607
Merge branch 'main' into grace-period-for-inaccessible-workspaces
ojpro Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions crates/workspace/src/persistence.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1850,12 +1850,10 @@ impl WorkspaceDb {
// If a local workspace points to WSL, this check will cause us to wait for the
// WSL VM and file server to boot up. This can block for many seconds.
// Supported scenarios use remote workspaces.
if !has_wsl_path
&& Self::all_paths_exist_with_a_directory(paths.paths(), fs, Some(timestamp)).await
{
result.push((id, SerializedWorkspaceLocation::Local, paths, timestamp));
} else {
if has_wsl_path || Utc::now() - timestamp >= chrono::Duration::days(7) {
delete_tasks.push(self.delete_workspace_by_id(id));
} else if Self::all_paths_exist_with_a_directory(paths.paths(), fs, None).await {
result.push((id, SerializedWorkspaceLocation::Local, paths, timestamp));

@maxbrunsfeld maxbrunsfeld Mar 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think we'd want to check if the paths exists first, before possibly deleting them. This seems like it will delete things even if they exist.

@ojpro ojpro Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I forgot to take that into consideration in this condition.

I will fix it soon.

}
}

Expand Down
Loading